Skip to content

DisruptionReason status condition isn't propagated for forceful disruptions #2023

Open
@jonathan-innis

Description

@jonathan-innis

Description

Observed Behavior:

DisruptionReason status condition was added to the disruption controller to inform users of the reason that they are seeing NodeClaim disruption directly on the object. We are also planning on using this information to pass details to metric counters so that we can track things like how many pods are disrupted for a given reason

This condition was added but wasn't added to forceful disruption reasons -- which means we are going to lack information when we delete nodes due to expiration, interruption (AWS), manually terminated, etc.

We should add this reason onto forceful disruptions before we actually initiate the termination of the NodeClaim.

Expected Behavior:

All disruption reasons should cause the DisruptionReason status condition to exist on the NodeClaim

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Metadata

Metadata

Assignees

Labels

good first issueDenotes an issue ready for a new contributor, according to the "help wanted" guidelines.help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.kind/bugCategorizes issue or PR as related to a bug.priority/important-soonMust be staffed and worked on either currently, or very soon, ideally in time for the next release.triage/acceptedIndicates an issue or PR is ready to be actively worked on.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions