[Draft] Feat: Np disruption status #2279
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: liafizan The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
needs-ok-to-test
|
Hi @liafizan. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
the
size/M
| @@ -79,7 +89,51 @@ func (c *Controller) Reconcile(ctx context.Context, nodePool *v1.NodePool) (reco | |||
| return reconcile.Result{RequeueAfter: time.Second}, nil | |||
| } | |||
| stored := nodePool.DeepCopy() | |||
| // Determine resource usage and update nodepool.status.resources | |||
|
|
|||
There was a problem hiding this comment.
Plan to refactor this if the approach looks good
|
/assign |
Fixes #2017
Description
Made changes for feedback on approach. Will refactor to reduce cognitive complexity as well as add tests if the approach looks ok
How was this change tested?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.