Skip to content

feat: Add configurable registration TTL #2313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

feat: Add configurable registration TTL #2313

wants to merge 5 commits into from
+57 −5

Conversation

GnatorX
Copy link

@GnatorX GnatorX commented Jun 16, 2025 •
edited
Loading

Fixes #357

Description
Based on #1989
How was this change tested?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 16, 2025
@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 16, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: GnatorX
Once this PR has been reviewed and has the lgtm label, please assign gjtempleton for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 16, 2025
@coveralls
Copy link

coveralls commented Jun 16, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 15687720068

Details

  • 4 of 14 (28.57%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.03%) to 81.982%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/controllers/nodeclaim/lifecycle/liveness.go 1 3 33.33%
pkg/apis/v1/zz_generated.deepcopy.go 2 10 20.0%
Totals Coverage Status
Change from base Build 15642318551: -0.03%
Covered Lines: 10265
Relevant Lines: 12521
💛 - Coveralls

engedaam
engedaam reviewed Jun 16, 2025
View reviewed changes
Copy link
Contributor

@engedaam engedaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few minor cleanup comments

pkg/apis/v1/nodeclaim.go Outdated
// +kubebuilder:validation:Pattern=`^([0-9]+(s|m|h))+$`
// +kubebuilder:validation:Type="string"
// +optional
RegistrationTTL *metav1.Duration `json:"registrationTTL,omitempty"`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we are not planning on drifting on this field, we need to add the hash:"ignore"

pkg/controllers/nodeclaim/lifecycle/liveness.go Outdated
@@ -41,7 +41,7 @@ type Liveness struct {

// registrationTTL is a heuristic time that we expect the node to register within
// If we don't see the node within this time, then we should delete the NodeClaim and try again
const registrationTTL = time.Minute * 15
var registrationTTL = time.Minute * 15
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider dropping this variable for the nodeclaim spec value

@GnatorX GnatorX changed the title Add registration TTL feat: Add configurable registration TTL Jun 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@engedaam engedaam engedaam left review comments

@tallaxes tallaxes Awaiting requested review from tallaxes

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow registration TTL to be user configurable
5 participants
@GnatorX @k8s-ci-robot @coveralls @engedaam @garvinp-stripe