Skip to content

Prow accepted invalid OWNERS_ALIASES change and broke approvals #360

@tuminoid

Description

@tuminoid

Issue

We use OWNERS file that points to aliases listed in OWNERS_ALIASES.

We promoted all of our reviewers to approvers in this PR, which then caused Prow to stop accepting approves, such as here and here.

Expected outcome

When merging PR116, Prow should've labeled the PR as "do-not-merge/invalid-owners-file" and blocked it.

Actual outcome

Prow/tide did not complain, we merged it, and noticed that approving was broken. Had to manually merge a fix PR, which then solved the situation right away.

Looking at the verify-owners_test.go:

  1. It seems it should fail to empty groups. I'm suspecting there is loophole due usage of OWNERS_ALIASES, which is much less tested here.
  2. Another alternative is the use of {} to signal empty group, which is valid YAML, but maybe not expected by Prow?

Logs

There was no error logs in Prow, just regular comment/approval handling logs, that did not indicate OWNERS was broken. It just claimed "comment did not result in approval".

Metadata

Metadata

Labels

area/pluginsIssues or PRs related to prow's plugins for the hook componentkind/bugCategorizes issue or PR as related to a bug.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions