-
Notifications
You must be signed in to change notification settings - Fork 312
feat: Add VolumeID to Mount request #1755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1755 +/- ##
==========================================
+ Coverage 35.83% 36.61% +0.77%
==========================================
Files 63 63
Lines 3759 4534 +775
==========================================
+ Hits 1347 1660 +313
- Misses 2268 2731 +463
+ Partials 144 143 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/assign aramase Rationale in linked issue seems reasonable but will defer to Anish since he is more familiar with CSI. |
3f45297
to
f9509d1
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: micahhausler The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
8957259
to
5c3eaa6
Compare
Signed-off-by: Micah Hausler <mhausler@amazon.com>
5c3eaa6
to
5428978
Compare
/retry |
@micahhausler: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look fine!
This can only be merged after we support RequiresRepublish
because the rotation controller doesn't have access to the volumeID.
/hold
token could differ between volume mounts (ex: pod1/mount1 uses token1 for credentials in cloud region us-east-1, pod1/mount2 uses the same token1 for credentials in cloud region us-west-2. The AWS provider allows such a configuration)
Isn't it easier for the provider to use the region in this case or other provider specific information another dimension of cache key? The pod uid will be the first dimension.
/retitle feat: Add VolumeID to Mount request |
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR adds the VolumeID to the request so providers can make smarter caching decisions once
requiresRepublish
is implemented.Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when the PR gets merged):Fixes #1754
Special notes for your reviewer:
I opted to name the key with the DNS namespace for this project as there isn't a corresponding CSI key I could find in the Kubernetes codebase (the volume ID is just an attribute of the request, not an encoded key). Let me know if there is a better key name to use
TODOs: