-
Notifications
You must be signed in to change notification settings - Fork 193
WLDI - TKG testcases #3291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
WLDI - TKG testcases #3291
Conversation
Hi @bn023052. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left minor comments, please address those, approving ahead
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bn023052, sipriyaa The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
This PR includes some basic tests on WLDI feature on TKG flavour
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #This PR includes some basic tests on WLDI feature on TKG flavour. Such as, creating statefulset with IMM & WFFC binding mode and validating the annotation/affinity.
Testing done:
Yes.
https://gist.github.com/bn023052/8440a3eddcc09d91272b7824e1ef1fc5
Special notes for your reviewer:
nayakb@RKJX93P79D vsphere-csi-driver % /Users/nayakb/go/bin/golangci-lint run --enable=lll --timeout 10m
nayakb@RKJX93P79D vsphere-csi-driver %