-
Notifications
You must be signed in to change notification settings - Fork 193
Add new CnsNodeVmBatchAttachment CRD and its reconcilation #3320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add new CnsNodeVmBatchAttachment CRD and its reconcilation #3320
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: skogta The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @skogta. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
4130679
to
bc4c2c8
Compare
PR title should say "Add new CnsNodeVmBatchAttachment CRD" |
58300fd
to
8b67065
Compare
3cca10c
to
e0c43b2
Compare
f158219
to
8e0726c
Compare
8e0726c
to
5c89fe4
Compare
What this PR does / why we need it:
This PR adds the CnsNodeVmBatchAttachment CRD to allow batch attach for multiple volumes attaching to the same VM.
Testing done:
Created the following CnsNodeVmBatchAttachment CR
Observed that status got updated:
Removed pvc-2 from the CR and observed that the status also got updated accordingly.
Verified from logs that attach and detach APIs are being called.
Yet to write unit tests.