-
Notifications
You must be signed in to change notification settings - Fork 193
Adding test constants files #3345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Hi @anuj087. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some comments
4dea2d0
to
1d05e22
Compare
3580e65
to
7927ee9
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: anuj087, rajguptavm The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Code Refactor: Move test constants to test/e2e/constants package
• Centralised commonly used test constants into a new test/e2e/constants package.
• Replaced hardcoded values in individual test files with shared constants to improve maintainability and consistency.
• Updated all relevant import paths across newly created util/client/connection(Not yet merged) packages.
• No changes to test logic or functionality. As current tests/utils use the older code only. Once all the code is merger, we can clean them up
This refactor simplifies updates to test data and reduces duplication across tests.
/e2e
├── constants
│ └── auth.go
│ └── commands.go
│ └── env_constants.go
│ └── ..
Note:
Testing in progress! I will update the description with results when available.