Skip to content

Adding test constants files #3345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

anuj087
Copy link
Contributor

@anuj087 anuj087 commented Jun 18, 2025

Code Refactor: Move test constants to test/e2e/constants package
• Centralised commonly used test constants into a new test/e2e/constants package.
• Replaced hardcoded values in individual test files with shared constants to improve maintainability and consistency.
• Updated all relevant import paths across newly created util/client/connection(Not yet merged) packages.
• No changes to test logic or functionality. As current tests/utils use the older code only. Once all the code is merger, we can clean them up

This refactor simplifies updates to test data and reduces duplication across tests.
/e2e
├── constants
│ └── auth.go
│ └── commands.go
│ └── env_constants.go
│ └── ..

Note:

  1. Still some refactoring is required for environment test constants. This we can do in later set of changes as package structure will remain same, and we just need to move them to different files.

Testing in progress! I will update the description with results when available.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 18, 2025
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 18, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @anuj087. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jun 18, 2025
Copy link
Contributor

@rajguptavm rajguptavm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments

@anuj087 anuj087 force-pushed the addingTestConstants branch from 4dea2d0 to 1d05e22 Compare June 19, 2025 10:42
@anuj087 anuj087 force-pushed the addingTestConstants branch from 3580e65 to 7927ee9 Compare June 19, 2025 10:52
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: anuj087, rajguptavm
Once this PR has been reviewed and has the lgtm label, please assign sipriyaa for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants