Skip to content

Update volume group snapshot KEP #5013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 16, 2025
Merged

Update volume group snapshot KEP #5013

merged 1 commit into from
Jun 16, 2025

Conversation

xing-yang
Copy link
Contributor

@xing-yang xing-yang commented Dec 23, 2024 •
edited
Loading

  • One-line PR description:
    Update KEP to incorporate changes made while moving the feature to Beta.
    Moved to beta in 1.32.
    Update API to v1beta2 in 1.34.
  • Other comments:

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory labels Dec 23, 2024
@k8s-ci-robot k8s-ci-robot added the sig/storage Categorizes an issue or PR as relevant to SIG Storage. label Dec 23, 2024
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 23, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 23, 2025
@xing-yang
Copy link
Contributor Author

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 17, 2025
@xing-yang xing-yang force-pushed the volumegroup_update_beta_api branch from fc0acd7 to e4210d9 Compare April 18, 2025 14:39
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 18, 2025
@xing-yang xing-yang force-pushed the volumegroup_update_beta_api branch 3 times, most recently from 6e98784 to 7d321d7 Compare April 28, 2025 03:21
@xing-yang xing-yang changed the title WIP: Update volume group snapshot KEP Update volume group snapshot KEP Apr 28, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 28, 2025
@nixpanic nixpanic mentioned this pull request Apr 29, 2025
Draft
gnufied
gnufied reviewed May 1, 2025
View reviewed changes
@xing-yang xing-yang force-pushed the volumegroup_update_beta_api branch from 7d321d7 to 526232e Compare May 14, 2025 17:39
Madhu-1
Madhu-1 reviewed May 15, 2025
View reviewed changes
@xing-yang xing-yang force-pushed the volumegroup_update_beta_api branch from 526232e to 9d61497 Compare May 29, 2025 02:26
Madhu-1
Madhu-1 reviewed May 30, 2025
View reviewed changes
Copy link

@Madhu-1 Madhu-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xing-yang xing-yang force-pushed the volumegroup_update_beta_api branch from 9d61497 to 9e1af21 Compare June 3, 2025 03:24
@xing-yang xing-yang mentioned this pull request Jun 3, 2025
Open
10 tasks
msau42
msau42 reviewed Jun 6, 2025
View reviewed changes
msau42
msau42 reviewed Jun 6, 2025
View reviewed changes
@xing-yang xing-yang force-pushed the volumegroup_update_beta_api branch from 9e1af21 to 128a33e Compare June 8, 2025 14:50
@xing-yang
Copy link
Contributor Author

@msau42 I addressed your comments. Please take another look. Thanks.

@xing-yang xing-yang force-pushed the volumegroup_update_beta_api branch from 128a33e to 98fc279 Compare June 8, 2025 15:52
@xing-yang
Copy link
Contributor Author

/assign @bridgetkromhout @johnbelamaric
for PRR reviews

@xing-yang xing-yang force-pushed the volumegroup_update_beta_api branch from 98fc279 to 41ddd2e Compare June 8, 2025 16:01
@xing-yang
Copy link
Contributor Author

/assign @bridgetkromhout

@xing-yang
Copy link
Contributor Author

/assign @johnbelamaric

@msau42
Copy link
Member

msau42 commented Jun 16, 2025

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 16, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msau42, xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 8dadcec into kubernetes:master Jun 16, 2025
3 of 4 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.34 milestone Jun 16, 2025
@leonardoce leonardoce mentioned this pull request Jun 25, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnufied gnufied

@Madhu-1 Madhu-1

@msau42 msau42

@johnbelamaric johnbelamaric

@saad-ali saad-ali

Assignees

@bridgetkromhout bridgetkromhout

@johnbelamaric johnbelamaric

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.34
Development

Successfully merging this pull request may close these issues.
8 participants
@xing-yang @k8s-triage-robot @msau42 @k8s-ci-robot @gnufied @Madhu-1 @bridgetkromhout @johnbelamaric