Skip to content

KEP-4412: promote wi for image pulls to beta in v1.34 #5374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 17, 2025

Conversation

aramase
Copy link
Member

@aramase aramase commented Jun 5, 2025

  • One-line PR description: Promote KEP-4412 to beta in v1.34
  • Other comments:
    • Post Alpha work has been moved into beta graduation (making this KEP work with KEP-2535)

/sig auth
/assign enj liggitt

Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com>
@k8s-ci-robot k8s-ci-robot added sig/auth Categorizes an issue or PR as relevant to SIG Auth. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 5, 2025
@k8s-ci-robot k8s-ci-robot requested review from enj and johnbelamaric June 5, 2025 06:13
@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 5, 2025
@aramase
Copy link
Member Author

aramase commented Jun 5, 2025

/assign @deads2k
for PRR

@enj enj added this to SIG Auth Jun 5, 2025
@enj enj moved this to Needs Triage in SIG Auth Jun 5, 2025
@aramase aramase moved this from Needs Triage to In Review in SIG Auth Jun 5, 2025
Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com>
@aramase aramase force-pushed the aramase/d/kep_4412_beta_v1.34 branch from 4f938e0 to 33bac62 Compare June 6, 2025 06:01
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 6, 2025
Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com>
@aramase aramase requested a review from kannon92 June 6, 2025 06:09
Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com>
@aramase aramase force-pushed the aramase/d/kep_4412_beta_v1.34 branch from a503e3f to b4d8f70 Compare June 6, 2025 22:00
Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com>
@aramase aramase force-pushed the aramase/d/kep_4412_beta_v1.34 branch from b4d8f70 to 12c60d8 Compare June 10, 2025 17:11
@aramase
Copy link
Member Author

aramase commented Jun 10, 2025

@kannon92 @deads2k any other update required for PRR approval?

@deads2k
Copy link
Contributor

deads2k commented Jun 11, 2025

@kannon92 @deads2k any other update required for PRR approval?

This thread looks open and important: https://github.com/kubernetes/enhancements/pull/5374/files#r2140017635 . A hashed metric of some kind would also alert cluster-admins if a privileged pod changed the configuration unexpectedly. I'm not sure how we'd know otherwise.

Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com>
@aramase aramase requested a review from deads2k June 11, 2025 22:45
@kannon92
Copy link
Contributor

PRR shadow:

LGTM

/assign @deads2k

@deads2k
Copy link
Contributor

deads2k commented Jun 16, 2025

both PRR and sig lgtm.

/approve

/assign @enj
I'll leave the lgtm with @enj to get a second set of eyes.

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 16, 2025
Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com>
@aramase aramase requested a review from enj June 17, 2025 00:28
@enj
Copy link
Member

enj commented Jun 17, 2025

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 17, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aramase, deads2k, enj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 6193b90 into kubernetes:master Jun 17, 2025
3 of 4 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.34 milestone Jun 17, 2025
@github-project-automation github-project-automation bot moved this from In Review to Closed / Done in SIG Auth Jun 17, 2025
@aramase aramase deleted the aramase/d/kep_4412_beta_v1.34 branch June 17, 2025 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/auth Categorizes an issue or PR as relevant to SIG Auth. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
Status: Closed / Done
Development

Successfully merging this pull request may close these issues.

8 participants