KEP-3973: update Consider Terminating Pods in Deployments #5398
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
atiratree
commented
Jun 11, 2025
atiratree
commented
- One-line PR description: update Consider Terminating Pods in Deployments KEP
- Issue link: Consider Terminating Pods in Deployments #3973
- Other comments:
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
size/M
atiratree
commented
Jun 11, 2025
Comment on lines
+658
to
+659
| DeploymentReplicaSetTerminatingReplicas feature should be enabled and graduated to beta first at least one release | ||
| before the DeploymentPodReplacementPolicy feature is. |
There was a problem hiding this comment.
Highlighting this. It would be nice to have the DeploymentReplicaSetTerminatingReplicas graduated first (hopefully in 1.34), as it is a prerequisite for the DeploymentPodReplacementPolicy.
|
/assign @soltysh |
This was referenced Jun 11, 2025
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: atiratree, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.