-
Notifications
You must be signed in to change notification settings - Fork 137
UI: Enhance Error Message Specificity in User Invite Modal #1053
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
if ( | ||
error && | ||
error.data && | ||
typeof error.data === 'object' && |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Create new error codes in the respective handlers.
Hi @FaheemOnHub, I've just pushed the latest updates to my backend PR: https://github.com/layer5io/meshery-cloud/pull/3527. Could you please take a look and let me know if any further modifications are needed? Separately, regarding my frontend PR, could you advise if this should now be closed, or if it still requires further updates or work from my side?😊 Thanks! |
as currently we don't have notification center, we could just display the short description in err. |
error && | ||
error.data && | ||
typeof error.data === 'object' && | ||
error.data.code === INVITE_EXISTING_USER_ERROR_CODE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it necessary to hardcode, we can directly display the error message 🤔
Hi @FaheemOnHub, thanks for the feedback! You're right, but the backend can send various error messages. My thinking was to specifically check for |
Notes for Reviewers
This PR fixes #1050
Reason for Changes
The primary goal is to improve the user experience by providing more specific and actionable feedback when an invitation fails due to common, understandable reasons. This allows users to better diagnose the issue.
By whitelisting specific messages for detailed display, I avoid exposing end-users to potentially confusing or overly technical error messages.