fix: Unify version display for public and private designs #1081
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zihan Kuang <zihan_kuang@outlook.com>
leecalcote
reviewed
Jun 18, 2025
| @@ -61,7 +61,7 @@ export const handleImage = async ({ | |||
| export const DEFAULT_DESIGN_VERSION = '0.0.0'; | |||
|
|
|||
| export const getVersion = (design: Pattern) => { | |||
| if (design.visibility === 'public') { | |||
| if (design.visibility === 'published') { | |||
There was a problem hiding this comment.
In the event that the design is "public", what happens? @zihanKuang
There was a problem hiding this comment.
Previously, if the design was public, it would display the published_version. After the changes, only published designs will show published_version. Public designs will now display their regular version
For private designs, they were already displaying the correct version. With the new logic, they now fall through the if condition and also display their version from within the try block.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes for Reviewers
This PR fixes: https://github.com/layer5io/meshery-cloud/issues/3585
Reason
There are three relevant states for a design: private, public, and published. The
privateandpublicstates should both reflect the current draft's version number, which is stored in theversionfield. Only apublisheddesign should display thepublished_version.The bug was that the UI was incorrectly displaying the
published_versionfor designs that were set topublic. This created problems:published_version, the UI would show an incorrect fallback value (like0.0.0or"").published_version, the UI would show an incorrect value.Fix
20250617_200454.mp4