Avoid duplicate code in interactive example #40249
Merged
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead, add grouping parentheses to one of the code locations. Thus make the interactive example more consistent with an example further down in the same page.
github-actions
bot
added
Content:JS
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Use `js-nolint` instead of `js` for the example code block. Otherwise the linter would complain about unnecessary grouping parenthesis.
|
Indeed my original commit caused a linting error. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Instead of having two identical lines in the example, add grouping parentheses to one of the code locations.
Thus make the interactive example more consistent with an example further down in the same page.
Motivation
I think the duplicate code is not helpful to readers of this interactive example.
Additional details
I think the duplicate code may have been introduced by some automated formatting that removed unnecessary grouping.
Not sure, if the proposed change will pass linting.
Would it help to use
js-nolintinstead ofjsfor the changed code block?Would
js-nolintplay nicelyinteractive-example?Related issues and pull requests
Not aware of any. Since this is a minor/cosmetic change, I have not raised a corresponding issue yet.