Skip to content

[python-package] Fix mypy checks in plotting.py #6899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

borchero
Copy link
Collaborator

Motivation

mypy currently fails with 36 errors in 6 files. One of these files is plotting.py.

Changes

This PR fixes the typing issues in plotting.py, eliminating 1 error and 1 file with errors.

Copy link
Collaborator

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this! Similar to my comments on #6898 and #6900, can you please add the warnings from mypy to the PR description, so we know what specific problem this is attempting to fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants