Fix: Duplicate Responses in 'generate' mode #191
+6
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you share where you are seeing the duplicates? |
See issue #190 |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the issue of duplicate responses in generate mode by sending only one answer message per synthesis.
- Removed the initial answer message dispatch before processing URLs.
- Added a conditional branch to send the answer when no URLs are present.
Comments suppressed due to low confidence (1)
code/core/generate_answer.py:220
- Consider adding an explanatory comment clarifying why the answer message is only sent when no URLs exist, to improve code maintainability.
# Send message with just the answer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In generate mode NLWeb returns the same answer twice.
See issue #190
@microsoft-github-policy-service agree company="iunera"