aiohttp increase max line and max field size of client session #211
+8
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… also allow these values to be injectable as constants
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aiohttp uses the default values for max_line_size and max_field_size for ClientSession and the db_load fails if it goes above this value.
https://docs.aiohttp.org/en/stable/client_reference.html
max_line_size: Maximum allowed size of lines in responses.
max_field_size: Maximum allowed size of header fields in responses.
And example of this failing is this load of the RSS feed:
python -m tools.db_load https://www.bhf.org.uk/rss/news RSSThis PR both increases the size to 32KB for both header and field sizes and allows it to be injectable when the
ClientSessionis initalised.