[CropAndLock] theme #38044
Merged
[CropAndLock] theme #38044
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@microsoft-github-policy-service agree |
|
nice!!!! |
crutkas
added
the
Needs-Review
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
yeelam-gordon
approved these changes
Jun 17, 2025
yeelam-gordon
pushed a commit
that referenced
this pull request
Jun 20, 2025
## Summary of the Pull Request Theme aware cropped windows. ## PR Checklist - [x] **Closes:** #28348 - [ ] **Communication:** I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected - [ ] **Tests:** Added/updated and all pass - [ ] **Localization:** All end user facing strings can be localized - [ ] **Dev docs:** Added/updated - [ ] **New binaries:** Added on the required places - [ ] [JSON for signing](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ESRPSigning_core.json) for new binaries - [ ] [WXS for installer](https://github.com/microsoft/PowerToys/blob/main/installer/PowerToysSetup/Product.wxs) for new binaries and localization folder - [ ] [YML for CI pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ci/templates/build-powertoys-steps.yml) for new test projects - [ ] [YML for signed pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/release.yml) - [ ] **Documentation updated:** If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/windows-uwp/tree/docs/hub/powertoys) and link it here: #xxx ## Detailed Description of the Pull Request / Additional comments Added a Theme aware implementation that was already found on other components, the only difference is that we are dealing with multiple windows. It will follow the Power Toys application theme, (windows too in case PowerToys follows the System). I decided to change the scope of a variable to not create a second control of croppedWindows, this may need to be taken into consideration. ## Validation Steps Performed Using Crop (Win + Ctrl + Shift +R) Crop one or multiple windows. All of them have the same theme as the application. Went to windows theme settings, change to light theme, the app changes accordingly. Same behavior was tested with Thumbnail (Win + Ctrl + Shift + T) Closing windows and changing the theme again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Theme aware cropped windows.
PR Checklist
Detailed Description of the Pull Request / Additional comments
Added a Theme aware implementation that was already found on other components, the only difference is that we are dealing with multiple windows.
It will follow the Power Toys application theme, (windows too in case PowerToys follows the System).
I decided to change the scope of a variable to not create a second control of croppedWindows, this may need to be taken into consideration.
Validation Steps Performed
Using Crop (Win + Ctrl + Shift +R)
Crop one or multiple windows.
All of them have the same theme as the application.
Went to windows theme settings, change to light theme, the app changes accordingly.
Same behavior was tested with Thumbnail (Win + Ctrl + Shift + T)
Closing windows and changing the theme again.