Added basic support for Windows App Actions. #39927

azchohfi · 2025-06-06T00:58:34Z

Summary of the Pull Request

Adds basic support for finding, listing, and executing Windows App Actions on files found by the Microsoft.CmdPal.Ext.Indexer extension.

PR Checklist

Detailed Description of the Pull Request / Additional comments

We also update cswin32 to stable version.

Validation Steps Performed

Validated that it doesn't show on older versions of Windows (<26100 insiders) and that it does work on newer version that have the App Actions runtime.

moooyo

Please do not add new PInvoke call in cmdpal. We are trying to make it become native aot.

src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.Indexer/Actions/ActionRuntimeFactory.cs

src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.Indexer/NativeMethods.txt

moooyo · 2025-06-06T08:20:00Z

I'm not sure if it's suitable for indexer extension. I guess we need to create a new ext for it?

At least, I think we need to add a new setting to control this behaviour.

@zadjii-msft @cinnamon-msft

any idea?

Copilot

Pull Request Overview

This PR adds basic support for Windows App Actions by updating Windows SDK and related package versions while introducing new actions handling commands into the Command Palette.

Update package versions and Windows SDK target versions
Introduce ActionsListContextItem along with supporting commands and runtime for handling app actions
Update project configuration files and resource definitions to support new actions

Reviewed Changes

Copilot reviewed 20 out of 21 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
packages.config	Updated Microsoft.Windows.SDK.BuildTools version to 10.0.26100.4188
Microsoft.CommandPalette.Extensions.vcxproj	Updated WindowsTargetPlatformVersion to 10.0.26100.0
Utilities.cs	Removed redundant cast from flag parameter
DefaultBrowserInfo.cs	Updated SHLoadIndirectString call to use new syntax and pointer handling
Resources.resx	Added new localized string for actions
Icons.cs	Added new icon for actions support
ActionsListContextItem.cs	Introduced new context item for listing available actions based on file type
NativeMethods.json, NativeHelpers.cs	Updated COM related constants and settings
IndexerListItem.cs	Modified MoreCommands to conditionally include the new actions context item
ExecuteActionCommand.cs	Added new command for executing a selected Windows App Action
ActionRuntimeFactory.cs	Added factory for creating an ActionRuntime instance
UWPApplication.cs	Updated resource loading with updated SHLoadIndirectString usage
Common.Dotnet.CsWinRT.props, Directory.Packages.props, Cpp.Build.props, .vsconfig	Revised SDK/package versions to align with new Windows SDK support

Files not reviewed (1)

src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.Indexer/Properties/Resources.Designer.cs: Language not supported

Copilot · 2025-06-10T04:41:04Z

src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.WebSearch/Helpers/DefaultBrowserInfo.cs

-                        == 0)
-                    {
-                        return new string(buffer);
+                            default) == 0)


It appears there is an extra closing parenthesis when passing 'default' as the fourth argument to SHLoadIndirectString; please review and adjust the parameter parentheses so that the method call compiles correctly.

Copilot · 2025-06-10T04:41:04Z

src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.Indexer/Pages/ActionsListContextItem.cs

+internal sealed partial class ActionsListContextItem : CommandContextItem
+{
+    private readonly string fullPath;
+    private readonly List<CommandContextItem> actions = [];


The empty list initializer using '[]' is not a standard way to initialize a List in C#; consider using 'new List()' instead.

Suggested change

private readonly List<CommandContextItem> actions = [];

private readonly List<CommandContextItem> actions = new List<CommandContextItem>();

src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.Indexer/Commands/ExecuteActionCommand.cs

yeelam-gordon

@azchohfi, can you show some screenshot as well as part of the PR description?
Looks like we support 3 experiences now:
a. Photos (hardcode extension list)
b. Docs (hardcode extension list)
c. Normal Files (any others)

@cinnamon-msft and @niels9001, please review the experience.

yeelam-gordon · 2025-06-10T05:14:25Z

src/Common.Dotnet.CsWinRT.props

@@ -4,8 +4,8 @@
  <Import Project=".\Common.Dotnet.PrepareGeneratedFolder.targets" />

  <PropertyGroup>
-    <WindowsSdkPackageVersion>10.0.22621.57</WindowsSdkPackageVersion>
-    <TargetFramework>net9.0-windows10.0.22621.0</TargetFramework>
+    <WindowsSdkPackageVersion>10.0.26100.68-preview</WindowsSdkPackageVersion>


Thus, it is not only Win11, but even need more advanced version?
Given Powertoys support from Win10 to Win11, asking this to see what experience it can be.

Looks like since we specified SupportedOSPlatformVersion, during build time will tell us as warning if we access any API only support in higher version of OS.

I don't see warning about API usage like CA1416;CS8776, we should be good.

src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.Indexer/Data/IndexerListItem.cs

zadjii-msft · 2025-06-10T10:53:05Z

Here's a small GIF

(admittedly, I had to make a small change to support this - I had to change

-this.Name = actionInstance.DisplayInfo.Description
+this.Name = actionInstance.Definition.Description

in ExecuteActionCommand.cs. Presumably I'm on the wrong OS build for that API. But I also don't hate this?

We have other Big Ideas here with Actions and Command Palette (which I'll probably start working on more again in July when I'm back)

zadjii-msft

I'm like mostly okay with this. Couple nits - I didn't read the code too carefully. But it's cool, that's for sure.

Updating the SDK version is always scary (Terminal's hit some breaking changes in the past with SDK updates 🙃) but What Could Go Wrong?

Hopefully we'll see more than just a couple actions showing up in here soon 😉

zadjii-msft · 2025-06-10T10:55:47Z

.vsconfig

@@ -9,6 +9,7 @@
    "Microsoft.VisualStudio.Component.Windows10SDK.19041",
    "Microsoft.VisualStudio.Component.Windows10SDK.20348",
    "Microsoft.VisualStudio.Component.Windows10SDK.22621",


This isn't specific to this PR:
@crutkas have we been just adding new SDK versions to our .vsconfig this whole time? Presumably we don't need all of them - only the latest, right? We can probably prune this down, yea?

src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.Indexer/Pages/ActionsListContextItem.cs

src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.Indexer/Properties/Resources.resx

src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.Indexer/Pages/ActionsListContextItem.cs

zadjii-msft · 2025-06-10T11:03:38Z

src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.Indexer/Pages/ActionsListContextItem.cs

+            if (actionRuntime == null)
+            {
+                actionRuntime = ActionRuntimeFactory.CreateActionRuntime();
+                Task.Delay(500).Wait();


this looks sus - why wait 500ms here?

This is a bug we uncovered on the runtime last minute... It will be fixed, but its not yet, so if we don't add this, all instant calls to the runtime hung...

zadjii-msft · 2025-06-10T11:06:51Z

src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.Indexer/Pages/ActionsListContextItem.cs

+            }
+
+            actionRuntime.ActionCatalog.Changed -= ActionCatalog_Changed;
+            actionRuntime.ActionCatalog.Changed += ActionCatalog_Changed;


do we need to remove this event handler in our dtor?

(this is just me being mid at C# - I forget if these event handlers are smart and will get cleaned up for us or not)

This is a good question, but I had no easy solution here. The actionRuntime is static, so we don't recreate it all the time, so this event subscription will keep a hold of the instance of ActionsListContextItem that holds the ActionCatalog_Changed instance method. There is no dctor here to be called, or any pattern actually that would suffice without adding something into the toolkit, since the object won't be disposed by the garbage collector. This object is passed down to the MoreItems property of the ListItem, and, AFAIK, there is no such concept of being dismissed or anything like that.

The reason we have this event handler to begin with is to handle the case where the user typed something, it returned a list of actions, but then something happens and the available actions change (multiple different things could have happened, like a user signed out of the account and they decided to make the action not available, or there is a quota and that quota is over, so it should not be available, or the user uninstalled, or installed, an app).

src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.Indexer/Data/IndexerListItem.cs

zadjii-msft · 2025-06-10T11:10:12Z

src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.Indexer/Commands/ExecuteActionCommand.cs

+        this.Icon = new IconInfo(actionInstance.Definition.IconFullPath);
+    }
+
+    public override CommandResult Invoke()


note to self: this is the canonical example of #38326

Yes, please.

cinnamon-msft · 2025-06-10T18:39:38Z

From a PM stance I'm cool with this, looks like a nice toe-dip into Actions and I'm eager to see community feedback on it :)

Solved

Directory.Packages.props

…/Resources.resx Co-authored-by: Mike Griese <migrie@microsoft.com>

lei9444 · 2025-06-16T04:21:14Z

/azp run

azure-pipelines · 2025-06-16T04:21:24Z

Azure Pipelines successfully started running 1 pipeline(s).

…zollin/actionsInvoke

lei9444 · 2025-06-16T07:20:47Z

/azp run

azure-pipelines · 2025-06-16T07:20:56Z

Azure Pipelines successfully started running 1 pipeline(s).

lei9444 · 2025-06-16T09:01:53Z

/azp run

azure-pipelines · 2025-06-16T09:02:02Z

Azure Pipelines successfully started running 1 pipeline(s).

lei9444 · 2025-06-16T09:47:26Z

/azp run

azure-pipelines · 2025-06-16T09:47:36Z

Azure Pipelines successfully started running 1 pipeline(s).

lei9444 · 2025-06-16T10:44:49Z

/azp run

azure-pipelines · 2025-06-16T10:44:58Z

Azure Pipelines successfully started running 1 pipeline(s).

lei9444 · 2025-06-17T00:51:47Z

/azp run

azure-pipelines · 2025-06-17T00:51:55Z

Azure Pipelines successfully started running 1 pipeline(s).

yeelam-gordon · 2025-06-18T05:33:22Z

src/Common.Dotnet.CsWinRT.props

@@ -4,8 +4,8 @@
  <Import Project=".\Common.Dotnet.PrepareGeneratedFolder.targets" />

  <PropertyGroup>
-    <WindowsSdkPackageVersion>10.0.22621.57</WindowsSdkPackageVersion>
-    <TargetFramework>net9.0-windows10.0.22621.0</TargetFramework>
+    <WindowsSdkPackageVersion>10.0.26100.68-preview</WindowsSdkPackageVersion>


Looks like since we specified SupportedOSPlatformVersion, during build time will tell us as warning if we access any API only support in higher version of OS.

I don't see warning about API usage like CA1416;CS8776, we should be good.

src/modules/cmdpal/ExtensionTemplate/TemplateCmdPalExtension/Directory.Packages.props

lei9444 · 2025-06-18T06:23:22Z

/azp run

azure-pipelines · 2025-06-18T06:23:32Z

Azure Pipelines successfully started running 1 pipeline(s).

## Summary of the Pull Request Adds basic support for finding, listing, and executing Windows App Actions on files found by the Microsoft.CmdPal.Ext.Indexer extension. ## PR Checklist - [X] **Closes:** #39926 - [X] **Communication:** I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected - [ ] **Tests:** Added/updated and all pass - [X] **Localization:** All end user facing strings can be localized - [ ] **Dev docs:** Added/updated - [ ] **New binaries:** Added on the required places - [ ] [JSON for signing](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ESRPSigning_core.json) for new binaries - [ ] [WXS for installer](https://github.com/microsoft/PowerToys/blob/main/installer/PowerToysSetup/Product.wxs) for new binaries and localization folder - [ ] [YML for CI pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ci/templates/build-powertoys-steps.yml) for new test projects - [ ] [YML for signed pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/release.yml) - [ ] **Documentation updated:** If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/windows-uwp/tree/docs/hub/powertoys) and link it here: #xxx ## Detailed Description of the Pull Request / Additional comments We also update cswin32 to stable version.  ## Validation Steps Performed Validated that it doesn't show on older versions of Windows (<26100 insiders) and that it does work on newer version that have the App Actions runtime. --------- Co-authored-by: Gordon Lam (SH) <yeelam@microsoft.com> Co-authored-by: Mike Griese <migrie@microsoft.com> Co-authored-by: Leilei Zhang <leilzh@microsoft.com>

azchohfi requested a review from a team as a code owner June 6, 2025 00:58

moooyo previously requested changes Jun 6, 2025

View reviewed changes

src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.Indexer/Actions/ActionRuntimeFactory.cs Outdated Show resolved Hide resolved

src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.Indexer/NativeMethods.txt Outdated Show resolved Hide resolved

This comment has been minimized.

Sign in to view

yeelam-gordon requested a review from Copilot June 10, 2025 04:40

yeelam-gordon added the Product-Command Palette label Jun 10, 2025

Copilot AI reviewed Jun 10, 2025

View reviewed changes

yeelam-gordon requested a review from cinnamon-msft June 10, 2025 04:53

yeelam-gordon reviewed Jun 10, 2025

View reviewed changes

yeelam-gordon assigned cinnamon-msft Jun 10, 2025

yeelam-gordon added the Needs-Triage label Jun 10, 2025

zadjii-msft reviewed Jun 10, 2025

View reviewed changes

This comment has been minimized.

Sign in to view

moooyo self-requested a review June 11, 2025 01:51

yeelam-gordon assigned lei9444 and unassigned cinnamon-msft Jun 11, 2025

yeelam-gordon requested a review from lei9444 June 11, 2025 10:08

yeelam-gordon added Needs-Review and removed Needs-Triage labels Jun 11, 2025

lei9444 reviewed Jun 12, 2025

View reviewed changes

Directory.Packages.props Show resolved Hide resolved

yeelam-gordon and others added 4 commits June 12, 2025 10:30

Rebased with main

39fa4c3

Addressed PR Feedback.

54f7e1e

Update src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.Indexer/Properties…

1870fc3

…/Resources.resx Co-authored-by: Mike Griese <migrie@microsoft.com>

Added lock for UpdateMoreCommands.

d168ae5

yeelam-gordon force-pushed the alzollin/actionsInvoke branch from af87ba3 to d168ae5 Compare June 12, 2025 02:31

This comment has been minimized.

Sign in to view

lei9444 added 2 commits June 16, 2025 13:59

Merge branch 'main' of https://github.com/microsoft/PowerToys into al…

821f0b7

…zollin/actionsInvoke

update version

e53961c

update all version

c2975df

update NOTICE.md

3bf0c04

add more version

041cdc5

fix the version

34bacdf

zadjii-msft approved these changes Jun 17, 2025

View reviewed changes

lei9444 approved these changes Jun 18, 2025

View reviewed changes

yeelam-gordon approved these changes Jun 18, 2025

View reviewed changes

update template version

d0f45a3

vanzue approved these changes Jun 18, 2025

View reviewed changes

lei9444 merged commit 4737ec9 into microsoft:main Jun 18, 2025
9 checks passed

zadjii-msft linked an issue Jun 18, 2025 that may be closed by this pull request

Add Windows App Actions support. #39926

Closed

yeelam-gordon added this to the PowerToys 0.92 milestone Jun 24, 2025

yeelam-gordon removed the Needs-Review label Jun 24, 2025

	private readonly List<CommandContextItem> actions = [];
	private readonly List<CommandContextItem> actions = new List<CommandContextItem>();

Added basic support for Windows App Actions. #39927

Added basic support for Windows App Actions. #39927

Conversation

azchohfi commented Jun 6, 2025

Summary of the Pull Request

PR Checklist

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

Uh oh!

moooyo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

moooyo commented Jun 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Jun 10, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jun 10, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

yeelam-gordon left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

yeelam-gordon Jun 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

zadjii-msft commented Jun 10, 2025

Uh oh!

zadjii-msft left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

This comment has been minimized.

cinnamon-msft commented Jun 10, 2025

Uh oh!

Uh oh!

This comment has been minimized.

lei9444 commented Jun 16, 2025

Uh oh!

azure-pipelines bot commented Jun 16, 2025

Uh oh!

lei9444 commented Jun 16, 2025

Uh oh!

azure-pipelines bot commented Jun 16, 2025

Uh oh!

lei9444 commented Jun 16, 2025

Uh oh!

azure-pipelines bot commented Jun 16, 2025

moooyo commented Jun 6, 2025 •

edited

Loading

yeelam-gordon Jun 18, 2025 •

edited

Loading

yeelam-gordon Jun 18, 2025 •

edited

Loading