Skip to content

[Hosts]Add learn more link to warning dialog #39946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 16, 2025

Conversation

PesBandi
Copy link
Contributor

@PesBandi PesBandi commented Jun 7, 2025

Summary of the Pull Request

Adds a Learn more link pointing here (the same as in the settings) to the warning dialog that shows up when Hosts File Editor starts

PR Checklist

  • Closes: [Hosts] Add "Learn more" link to the Hosts File Editor warning #39859
  • Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
  • Tests: Added/updated and all pass
  • Localization: All end user facing strings can be localized
  • Dev docs: No need
  • New binaries: None
  • Documentation updated: No need

Detailed Description of the Pull Request / Additional comments

Image

Validation Steps Performed

Tested the UI manually

@yeelam-gordon yeelam-gordon added the Product-Hosts File Editor Refers to the Hosts file editor label Jun 10, 2025
@yeelam-gordon yeelam-gordon added this to the PowerToys 0.92 milestone Jun 10, 2025
@yeelam-gordon
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@yeelam-gordon yeelam-gordon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, tried out locally and it works perfect ;-)

@yeelam-gordon yeelam-gordon merged commit 3afaa18 into microsoft:main Jun 16, 2025
10 checks passed
@PesBandi PesBandi deleted the hosts-learn-more branch June 16, 2025 06:10
yeelam-gordon pushed a commit that referenced this pull request Jun 20, 2025
## Summary of the Pull Request
Adds a *Learn more* link pointing
[here](https://aka.ms/PowerToysOverview_HostsFileEditor) (the same as in
the settings) to the warning dialog that shows up when Hosts File Editor
starts
## PR Checklist
- [x] **Closes:** #39859
- [ ] **Communication:** I've discussed this with core contributors
already. If work hasn't been agreed, this work might be rejected
- [ ] **Tests:** Added/updated and all pass
- [x] **Localization:** All end user facing strings can be localized
- [x] **Dev docs:** No need
- [x] **New binaries:** None
- [x] **Documentation updated:** No need
## Detailed Description of the Pull Request / Additional comments

![Image](https://github.com/user-attachments/assets/f26c4fc9-fc3f-45d1-9976-77295b524b97)
<!-- Describe how you validated the behavior. Add automated tests
wherever possible, but list manual validation steps taken as well -->
## Validation Steps Performed
Tested the UI manually
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
In for .92 Product-Hosts File Editor Refers to the Hosts file editor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants