-
Notifications
You must be signed in to change notification settings - Fork 7.1k
CmdPal: entirely redo the Run page #39955
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
zadjii-msft
wants to merge
28
commits into
main
Choose a base branch
from
dev/migrie/f/run-page-2-with-suggestions
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #39419 This can be moved to its own branch.
src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.Shell/Pages/ShellListPage.cs
Fixed
Show fixed
Hide fixed
src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.Shell/Pages/ShellListPage.cs
Fixed
Show fixed
Hide fixed
…-2-with-suggestions
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just filing so I can track my remaining todo's
This entirely rewrites the shell page. It feels a lot more like the old run dialog now.
commands /with args...
%environmentVariables%
"Paths with\spaces in them"
References:
#39044
#39419
#38298
Remaining todo's
GenerateAppxManifest
change, and file something to fix that. We are still generating msix's on every build, wtfshell:
paths and weird URI's just work. Good test isx-cmdpal://settings
further optimizations that probably aren't blocking
c:\windows\s
->c:\windows\sys
), we should cache the ListItem's from the first query, and re-use them if possible.