Skip to content

CmdPal: entirely redo the Run page #39955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 28 commits into
base: main
Choose a base branch
from

Conversation

zadjii-msft
Copy link
Member

@zadjii-msft zadjii-msft commented Jun 8, 2025

Just filing so I can track my remaining todo's

This entirely rewrites the shell page. It feels a lot more like the old run dialog now.

  • It's got icons for files & exes
  • it can handle network paths
  • it can handle commands /with args...
  • it'll suggest files in that path as you type
  • it handles %environmentVariables%
  • it handles "Paths with\spaces in them"
  • it shows you the path as a suggestion, in the text box, as you move the selection

References:
#39044
#39419
#38298

Remaining todo's

  • Remove the GenerateAppxManifest change, and file something to fix that. We are still generating msix's on every build, wtf
  • Clean-up code
  • Double-check loc
  • Remove a bunch of debug printing that we don't need anymore
  • File a separate PR for moving the file (indexer) commands into a common project, and re-use those here
  • Add history support again! I totally tore that out
  • make shell: paths and weird URI's just work. Good test is x-cmdpal://settings

further optimizations that probably aren't blocking

  • Our fast up-to-date is clearly broken, but I think that's been broken since early 0.91
  • If the exe doesn't change, we don't need to create a new ListItem for it. We can just re-use the current one, and just change the args
  • if the directory hasn't changed, but we typed more chars (e.g. c:\windows\s -> c:\windows\sys), we should cache the ListItem's from the first query, and re-use them if possible.

@zadjii-msft zadjii-msft self-assigned this Jun 8, 2025
@zadjii-msft zadjii-msft added the Product-Command Palette Refers to the Command Palette utility label Jun 8, 2025

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Product-Command Palette Refers to the Command Palette utility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant