Fix Peek always showing warning message by updating IsWarningMessageVisible logic #40056
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yeelam-gordon
approved these changes
Jun 16, 2025
yeelam-gordon
added
the
Run-Plugin
yeelam-gordon
added
Product-Peek
yeelam-gordon
pushed a commit
that referenced
this pull request
Jun 20, 2025
…isible logic (#40056) <!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? --> ## Summary of the Pull Request This PR fixes an issue where the warning message in Peek was always displayed, even when not applicable. **Root cause** When non-video files were triggered, the logic did not call `IsWarningMessageVisible(string? missingCodecName)` as expected. As a result, the default UI state caused the warning message to always appear. **Fix** Updated the method signature and call sites to: `public Visibility IsWarningMessageVisible(IPreviewer? previewer, PreviewState? state)` This ensures that the logic is consistently triggered across different preview handlers and has access to the necessary context to determine whether the warning message should be shown. <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist - [ ] **Closes:** #xxx - [ ] **Communication:** I've discussed this with core contributors already. If the work hasn't been agreed, this work might be rejected - [ ] **Tests:** Added/updated and all pass - [ ] **Localization:** All end-user-facing strings can be localized - [ ] **Dev docs:** Added/updated - [ ] **New binaries:** Added on the required places - [ ] [JSON for signing](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ESRPSigning_core.json) for new binaries - [ ] [WXS for installer](https://github.com/microsoft/PowerToys/blob/main/installer/PowerToysSetup/Product.wxs) for new binaries and localization folder - [ ] [YML for CI pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ci/templates/build-powertoys-steps.yml) for new test projects - [ ] [YML for signed pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/release.yml) - [ ] **Documentation updated:** If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/windows-uwp/tree/docs/hub/powertoys) and link it here: #xxx <!-- Provide a more detailed description of the PR, other things fixed, or any additional comments/features here --> ## Detailed Description of the Pull Request / Additional comments <!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well --> ## Validation Steps Performed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
This PR fixes an issue where the warning message in Peek was always displayed, even when not applicable.
Root cause
When non-video files were triggered, the logic did not call
IsWarningMessageVisible(string? missingCodecName)as expected. As a result, the default UI state caused the warning message to always appear.
Fix
Updated the method signature and call sites to:
public Visibility IsWarningMessageVisible(IPreviewer? previewer, PreviewState? state)This ensures that the logic is consistently triggered across different preview handlers and has access to the necessary context to determine whether the warning message should be shown.
PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed