Settings: Generate bug report should tell user there is bug report generating #40060
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: vanzue <69313318+vanzue@users.noreply.github.com>
Co-authored-by: vanzue <69313318+vanzue@users.noreply.github.com>
Add visual feedback and state handling for bug report in progress
This comment has been minimized.
This comment has been minimized.
|
My two cents: This should affect tray menu entry/quick access too. And can we add a ProgressRing control? |
yeelam-gordon
added
the
Area-Bug Report Tool
There was a problem hiding this comment.
Pull Request Overview
This PR improves the bug report generation feedback by tracking the bug report status and reflecting it in the UI. Key changes include:
- Adding functions to check if a bug report is running and integrating this status via IPC.
- Enhancing the view models and UI pages to enable/disable the bug report button and show a progress indicator during bug report generation.
- Implementing corresponding changes in the runner modules to support status inquiries via IPC.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/settings-ui/Settings.UI/ViewModels/GeneralViewModel.cs | Introduced IsBugReportRunning property and CheckBugReportStatus method. |
| src/settings-ui/Settings.UI/ViewModels/Flyout/LauncherViewModel.cs | Added GetBugReportStatus method for IPC status requests. |
| src/settings-ui/Settings.UI/SettingsXAML/Views/GeneralPage.xaml.cs | Added a timer and IPC handlers to periodically check and update the bug report status. |
| src/settings-ui/Settings.UI/SettingsXAML/Views/GeneralPage.xaml | Updated the UI to show/hide the Report Bug button and a progress indicator based on bug report status. |
| src/runner/settings_window.cpp | Added IPC message handling for bug_report_status requests. |
| src/runner/bug_report.h & bug_report.cpp | Added declaration and implementation for is_bug_report_running(). |
Comments suppressed due to low confidence (1)
src/settings-ui/Settings.UI/SettingsXAML/Views/GeneralPage.xaml:466
- The x:Uid 'GeneralPage_ReportBugPackage' is used for two different SettingsCard elements, which may cause conflicts in localization or resource lookup. Consider renaming one of the identifiers to ensure uniqueness.
<tkcontrols:SettingsCard x:Uid="GeneralPage_ReportBugPackage" ...
This comment has been minimized.
This comment has been minimized.
Thanks for feedback, these are valuable, more than that, I implement observer pattern for bug report status, to enable event driven notification instead of polling. So icon change should be immediately instead of having to wait for a polling interval |
yeelam-gordon
approved these changes
Jun 17, 2025
yeelam-gordon
approved these changes
Jun 17, 2025
yeelam-gordon
pushed a commit
that referenced
this pull request
Jun 20, 2025
…nerating (#40060) ### <!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? --> ## Summary of the Pull Request ### Bug report tool status tracking: Currently, After clicking the generate package button, button is still active, as we do not have bug report progress, this will confuse user whether they actually clicks the button. Add an enable status to acknowledge the bug generating <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist - [ ] **Closes:** #xxx - [ ] **Communication:** I've discussed this with core contributors already. If the work hasn't been agreed, this work might be rejected - [x] **Tests:** Added/updated and all pass - [ ] **Localization:** All end-user-facing strings can be localized - [ ] **Dev docs:** Added/updated - [ ] **New binaries:** Added on the required places - [ ] [JSON for signing](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ESRPSigning_core.json) for new binaries - [ ] [WXS for installer](https://github.com/microsoft/PowerToys/blob/main/installer/PowerToysSetup/Product.wxs) for new binaries and localization folder - [ ] [YML for CI pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ci/templates/build-powertoys-steps.yml) for new test projects - [ ] [YML for signed pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/release.yml) - [ ] **Documentation updated:** If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/windows-uwp/tree/docs/hub/powertoys) and link it here: #xxx ## Detailed Description of the Pull Request / Additional comments 1. Progress bar should be present in generating report place when there is bug report going on. 2. Runner&Settings should know each other when they trigger the bug report. 3. Runner tray icon menu item should be disabled when there is one bug report going on. 4. After bug report generation, everything should be like before. ## Validation Steps Performed https://github.com/user-attachments/assets/dcbf8e6e-c5e1-4d23-9dab-f16c11ed56cf --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Bug report tool status tracking:
Currently, After clicking the generate package button, button is still active, as we do not have bug report progress, this will confuse user whether they actually clicks the button.
Add an enable status to acknowledge the bug generating
PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed
bug_report_status.mp4