Skip to content

CmdPal: Fix our fast up to date check #40108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 19, 2025

Conversation

zadjii-msft
Copy link
Member

Closes #40102
Regressed when we added this extension

Closes #40102
Regressed when we added this extension
@zadjii-msft zadjii-msft added the Product-Command Palette Refers to the Command Palette utility label Jun 18, 2025
@yeelam-gordon yeelam-gordon requested a review from Copilot June 19, 2025 00:26
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses the regression in the fast up-to-date check by adjusting build output paths and asset handling in the CmdPal extension project.

  • Added a new OutputPath configuration to direct built outputs appropriately.
  • Modified asset inclusion rules by removing default None entries for PNG and SVG assets and explicitly updating the PNG content definition.
Comments suppressed due to low confidence (1)

src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.TimeDate/Microsoft.CmdPal.Ext.TimeDate.csproj:37

  • If the SVG asset is expected to be included in the output similarly to the PNG asset, consider adding an appropriate Content update rule for it or documenting the rationale for its removal.
    <None Remove="Assets\TimeDate.svg" />

@yeelam-gordon yeelam-gordon requested a review from moooyo June 19, 2025 00:26
@zadjii-msft zadjii-msft added the Needs-Review This Pull Request awaits the review of a maintainer. label Jun 19, 2025
@zadjii-msft zadjii-msft merged commit 8391042 into main Jun 19, 2025
14 checks passed
@zadjii-msft zadjii-msft deleted the dev/migrie/b/fastUpToDateCmdPal branch June 19, 2025 17:09
yeelam-gordon pushed a commit that referenced this pull request Jun 20, 2025
Closes #40102
Regressed when we added this extension
@yeelam-gordon yeelam-gordon added this to the PowerToys 0.92 milestone Jun 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs-Review This Pull Request awaits the review of a maintainer. Product-Command Palette Refers to the Command Palette utility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CmdPal: Our FastUpToDate check no longer works
3 participants