CmdPal: Refactoring ContextMenu adding separators, IsCritical styling, and right-click context menus for list items #40189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaeljolley
changed the title
michaeljolley
changed the title
michaeljolley
added
the
Product-Command Palette
niels9001
reviewed
Jun 25, 2025
src/modules/cmdpal/Microsoft.CmdPal.UI/Controls/ContextMenu.xaml
Outdated
Show resolved
Hide resolved
niels9001
reviewed
Jun 26, 2025
src/modules/cmdpal/Microsoft.CmdPal.UI/Controls/ContextMenu.xaml
Outdated
Show resolved
Hide resolved
niels9001
reviewed
Jun 26, 2025
src/modules/cmdpal/Microsoft.CmdPal.UI/Controls/ContextMenu.xaml
Outdated
Show resolved
Hide resolved
niels9001
reviewed
Jun 26, 2025
src/modules/cmdpal/Microsoft.CmdPal.UI/Controls/ContextMenu.xaml
Outdated
Show resolved
Hide resolved
niels9001
reviewed
Jun 26, 2025
niels9001
reviewed
Jun 26, 2025
niels9001
reviewed
Jun 26, 2025
src/modules/cmdpal/Microsoft.CmdPal.UI/Controls/ContextMenu.xaml
Outdated
Show resolved
Hide resolved
niels9001
reviewed
Jun 26, 2025
niels9001
reviewed
Jun 26, 2025
| HorizontalAlignment="Left" | ||
| SourceKey="{x:Bind Icon, Mode=OneWay}" | ||
| SourceRequested="{x:Bind help:IconCacheProvider.SourceRequested}" /> | ||
| <TextBlock |
There was a problem hiding this comment.
Unrelated to this PR.. do we need to set the text trimming here (and to default to ...) in case the text is really long? Not sure how a default ContextMenu handles this? I guess we wouldn't want textwrapping and stick to a single line
niels9001
reviewed
Jun 26, 2025
src/modules/cmdpal/Microsoft.CmdPal.UI/Controls/ContextMenu.xaml
Outdated
Show resolved
Hide resolved
niels9001
reviewed
Jun 26, 2025
niels9001
reviewed
Jun 26, 2025
src/modules/cmdpal/Microsoft.CmdPal.UI/Controls/ContextMenu.xaml
Outdated
Show resolved
Hide resolved
niels9001
reviewed
Jun 26, 2025
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored ContextMenu into it's own control to allow displaying in CommandBar and in response to right click on list items.
IsCritical. This will use the theme to style with correct color.SeparatorContextItemand modifiedMoreCommandsto allow for bothCommandContextItems andSeparatorContextItems.This PR covers:
IsCriticalstyling on the context menu #38307