Skip to content

LEGO: Pull request from lego/hb_5378966c-b857-470a-8675-daebef4a6da1_20250611192551558 to main #61846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

csigs
Copy link
Member

@csigs csigs commented Jun 11, 2025

LEGO: Pull request from lego/hb_5378966c-b857-470a-8675-daebef4a6da1_20250611192551558 to main with localized lcls

@Copilot Copilot AI review requested due to automatic review settings June 11, 2025 19:26
@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Jun 11, 2025
@github-project-automation github-project-automation bot moved this to Not started in PR Backlog Jun 11, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds new diagnostic message entries and their localized translations across multiple languages to support recent deferred import checks and related recommendations.

  • Introduces messages for deferred import restrictions, environment/settings UI labels, and npm installation hints.
  • Localizes these entries in Turkish, Russian, Portuguese, Polish, Korean, Japanese, Italian, French, Spanish, German, Czech, Traditional Chinese, and Simplified Chinese.

Reviewed Changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/loc/lcl/trk/diagnosticMessages/diagnosticMessages.generated.json.lcl Added Turkish translations for new diagnostic messages
src/loc/lcl/rus/diagnosticMessages/diagnosticMessages.generated.json.lcl Added Russian translations for new diagnostic messages
src/loc/lcl/ptb/diagnosticMessages/diagnosticMessages.generated.json.lcl Added Brazilian Portuguese translations for new diagnostic messages
src/loc/lcl/plk/diagnosticMessages/diagnosticMessages.generated.json.lcl Added Polish translations for new diagnostic messages
src/loc/lcl/kor/diagnosticMessages/diagnosticMessages.generated.json.lcl Added Korean translations for new diagnostic messages
src/loc/lcl/jpn/diagnosticMessages/diagnosticMessages.generated.json.lcl Added Japanese translations for new diagnostic messages
src/loc/lcl/ita/diagnosticMessages/diagnosticMessages.generated.json.lcl Added Italian translations for new diagnostic messages
src/loc/lcl/fra/diagnosticMessages/diagnosticMessages.generated.json.lcl Added French translations for new diagnostic messages
src/loc/lcl/esn/diagnosticMessages/diagnosticMessages.generated.json.lcl Added Spanish translations for new diagnostic messages
src/loc/lcl/deu/diagnosticMessages/diagnosticMessages.generated.json.lcl Added German translations for new diagnostic messages
src/loc/lcl/csy/diagnosticMessages/diagnosticMessages.generated.json.lcl Added Czech translations for new diagnostic messages
src/loc/lcl/cht/diagnosticMessages/diagnosticMessages.generated.json.lcl Added Traditional Chinese translations for new diagnostic messages
src/loc/lcl/chs/diagnosticMessages/diagnosticMessages.generated.json.lcl Added Simplified Chinese translations for new diagnostic messages

<Str Cat="Text">
<Val><![CDATA[and npm install -D @types/node]]></Val>
<Tgt Cat="Text" Stat="Loc" Orig="New">
<Val><![CDATA[和 npm 安装 -D @types/节点]]></Val>
Copy link
Preview

Copilot AI Jun 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The package name '@types/node' was translated to '@types/节点', which breaks the npm install command. It should remain '@types/node'.

Copilot uses AI. Check for mistakes.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment is correct :(

@github-project-automation github-project-automation bot moved this from Not started to Needs merge in PR Backlog Jun 11, 2025
@jakebailey jakebailey merged commit dd1e258 into main Jun 11, 2025
32 checks passed
@jakebailey jakebailey deleted the lego/hb_5378966c-b857-470a-8675-daebef4a6da1_20250611192551558 branch June 11, 2025 20:57
@github-project-automation github-project-automation bot moved this from Needs merge to Done in PR Backlog Jun 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants