Skip to content

[experimental] Force strict binding #61888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[experimental] Force strict binding #61888

wants to merge 1 commit into from
+5,211 −1,097

Conversation

jakebailey
Copy link
Member

No description provided.

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Jun 17, 2025
@jakebailey
Copy link
Member Author

@typescript-bot test it

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jun 17, 2025 •
edited
Loading

Starting jobs; this comment will be updated as builds start and complete.

Command Status Results
test top400 ✅ Started ✅ Results
user test this ✅ Started ✅ Results
run dt ✅ Started 👀 Results
perf test this faster ✅ Started ❌ Results

@typescript-bot
Copy link
Collaborator

Hey @jakebailey, the results of running the DT tests are ready.

There were interesting changes:

Branch only errors:

Package: angular
Error:

Error: 
/mnt/vss/_work/1/DefinitelyTyped/types/angular/angular-tests.ts
  631:18  error  TypeScript@local compile error: 
Function declarations are not allowed inside blocks in strict mode when targeting 'ES5'  @definitelytyped/expect

✖ 1 problem (1 error, 0 warnings)

    at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.32_typescript@5.9.0-dev.20250617/node_modules/@definitelytyped/dtslint/dist/index.js:199:28)
    at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.32_typescript@5.9.0-dev.20250617/node_modules/@definitelytyped/dtslint/dist/index.js:191:20)

Package: snapsvg
Error:

Error: 
/mnt/vss/_work/1/DefinitelyTyped/types/snapsvg/test/3.ts
   76:18  error  TypeScript@local compile error: 
Function declarations are not allowed inside blocks in strict mode when targeting 'ES5'  @definitelytyped/expect
   83:18  error  TypeScript@local compile error: 
Function declarations are not allowed inside blocks in strict mode when targeting 'ES5'  @definitelytyped/expect
  115:18  error  TypeScript@local compile error: 
Function declarations are not allowed inside blocks in strict mode when targeting 'ES5'  @definitelytyped/expect
  263:18  error  TypeScript@local compile error: 
Function declarations are not allowed inside blocks in strict mode when targeting 'ES5'  @definitelytyped/expect

✖ 4 problems (4 errors, 0 warnings)

    at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.32_typescript@5.9.0-dev.20250617/node_modules/@definitelytyped/dtslint/dist/index.js:199:28)
    at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.32_typescript@5.9.0-dev.20250617/node_modules/@definitelytyped/dtslint/dist/index.js:191:20)

Package: lodash/v3
Error:

Error: 
/mnt/vss/_work/1/DefinitelyTyped/types/lodash/v3/lodash-tests.ts
  10601:14  error  TypeScript@local compile error: 
Function declarations are not allowed inside blocks in strict mode when targeting 'ES5'  @definitelytyped/expect
  10604:14  error  TypeScript@local compile error: 
Function declarations are not allowed inside blocks in strict mode when targeting 'ES5'  @definitelytyped/expect
  10607:14  error  TypeScript@local compile error: 
Function declarations are not allowed inside blocks in strict mode when targeting 'ES5'  @definitelytyped/expect
  10610:14  error  TypeScript@local compile error: 
Function declarations are not allowed inside blocks in strict mode when targeting 'ES5'  @definitelytyped/expect
  10613:14  error  TypeScript@local compile error: 
Function declarations are not allowed inside blocks in strict mode when targeting 'ES5'  @definitelytyped/expect

✖ 5 problems (5 errors, 0 warnings)

    at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.32_typescript@5.9.0-dev.20250617/node_modules/@definitelytyped/dtslint/dist/index.js:199:28)
    at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.32_typescript@5.9.0-dev.20250617/node_modules/@definitelytyped/dtslint/dist/index.js:191:20)

Package: maxmsp
Error:

Error: 
/mnt/vss/_work/1/DefinitelyTyped/types/maxmsp/index.d.ts
  10:13  error  TypeScript@local compile error: 
Invalid use of 'arguments' in strict mode  @definitelytyped/expect

✖ 1 problem (1 error, 0 warnings)

    at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.32_typescript@5.9.0-dev.20250617/node_modules/@definitelytyped/dtslint/dist/index.js:199:28)
    at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.32_typescript@5.9.0-dev.20250617/node_modules/@definitelytyped/dtslint/dist/index.js:191:20)

Package: codependency
Error:

Error: 
/mnt/vss/_work/1/DefinitelyTyped/types/codependency/codependency-tests.ts
  2:5  error  TypeScript@local compile error: 
Identifier expected. 'package' is a reserved word in strict mode  @definitelytyped/expect
  5:1  error  TypeScript@local compile error: 
Identifier expected. 'package' is a reserved word in strict mode  @definitelytyped/expect
  6:1  error  TypeScript@local compile error: 
Identifier expected. 'package' is a reserved word in strict mode  @definitelytyped/expect
  7:1  error  TypeScript@local compile error: 
Identifier expected. 'package' is a reserved word in strict mode  @definitelytyped/expect
  8:1  error  TypeScript@local compile error: 
Identifier expected. 'package' is a reserved word in strict mode  @definitelytyped/expect
  9:1  error  TypeScript@local compile error: 
Identifier expected. 'package' is a reserved word in strict mode  @definitelytyped/expect

✖ 6 problems (6 errors, 0 warnings)

    at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.32_typescript@5.9.0-dev.20250617/node_modules/@definitelytyped/dtslint/dist/index.js:199:28)
    at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.32_typescript@5.9.0-dev.20250617/node_modules/@definitelytyped/dtslint/dist/index.js:191:20)

Package: emscripten
Error:

Error: 
/mnt/vss/_work/1/DefinitelyTyped/types/emscripten/emscripten-tests.ts
  27:11  error  TypeScript@local compile error: 
Identifier expected. 'package' is a reserved word in strict mode  @definitelytyped/expect

✖ 1 problem (1 error, 0 warnings)

    at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.32_typescript@5.9.0-dev.20250617/node_modules/@definitelytyped/dtslint/dist/index.js:199:28)
    at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.32_typescript@5.9.0-dev.20250617/node_modules/@definitelytyped/dtslint/dist/index.js:191:20)

Package: is
Error:

Error: 
/mnt/vss/_work/1/DefinitelyTyped/types/is/is-tests.ts
  6:5  error  TypeScript@local compile error: 
Invalid use of 'arguments' in strict mode  @definitelytyped/expect

✖ 1 problem (1 error, 0 warnings)

    at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.32_typescript@5.9.0-dev.20250617/node_modules/@definitelytyped/dtslint/dist/index.js:199:28)
    at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.32_typescript@5.9.0-dev.20250617/node_modules/@definitelytyped/dtslint/dist/index.js:191:20)

Package: microsoft-ajax
Error:

Error: 
/mnt/vss/_work/1/DefinitelyTyped/types/microsoft-ajax/microsoft-ajax-tests.ts
  94:13  error  TypeScript@local compile error: 
Invalid use of 'arguments' in strict mode  @definitelytyped/expect

✖ 1 problem (1 error, 0 warnings)

    at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.32_typescript@5.9.0-dev.20250617/node_modules/@definitelytyped/dtslint/dist/index.js:199:28)
    at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.32_typescript@5.9.0-dev.20250617/node_modules/@definitelytyped/dtslint/dist/index.js:191:20)

Package: gapi.calendar
Error:

Error: 
/mnt/vss/_work/1/DefinitelyTyped/types/gapi.calendar/gapi.calendar-tests.ts
   13:14  error  TypeScript@local compile error: 
Function declarations are not allowed inside blocks in strict mode when targeting 'ES5'  @definitelytyped/expect
   29:14  error  TypeScript@local compile error: 
Function declarations are not allowed inside blocks in strict mode when targeting 'ES5'  @definitelytyped/expect
   47:14  error  TypeScript@local compile error: 
Function declarations are not allowed inside blocks in strict mode when targeting 'ES5'  @definitelytyped/expect
   59:14  error  TypeScript@local compile error: 
Function declarations are not allowed inside blocks in strict mode when targeting 'ES5'  @definitelytyped/expect
   68:14  error  TypeScript@local compile error: 
Function declarations are not allowed inside blocks in strict mode when targeting 'ES5'  @definitelytyped/expect
  103:14  error  TypeScript@local compile error: 
Function declarations are not allowed inside blocks in strict mode when targeting 'ES5'  @definitelytyped/expect
  152:9   error  TypeScript@local compile error: 
Cannot find name 'appendPre'                                                             @definitelytyped/expect
  155:14  error  TypeScript@local compile error: 
Function declarations are not allowed inside blocks in strict mode when targeting 'ES5'  @definitelytyped/expect
  164:17  error  TypeScript@local compile error: 
Cannot find name 'appendPre'                                                             @definitelytyped/expect
  167:17  error  TypeScript@local compile error: 
Cannot find name 'appendPre'                                                             @definitelytyped/expect

✖ 10 problems (10 errors, 0 warnings)

    at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.32_typescript@5.9.0-dev.20250617/node_modules/@definitelytyped/dtslint/dist/index.js:199:28)
    at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.32_typescript@5.9.0-dev.20250617/node_modules/@definitelytyped/dtslint/dist/index.js:191:20)

Package: espruino
Error:

Error: 
/mnt/vss/_work/1/DefinitelyTyped/types/espruino/index.d.ts
  3808:13  error  TypeScript@local compile error: 
Invalid use of 'arguments' in strict mode  @definitelytyped/expect

✖ 1 problem (1 error, 0 warnings)

    at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.32_typescript@5.9.0-dev.20250617/node_modules/@definitelytyped/dtslint/dist/index.js:199:28)
    at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.32_typescript@5.9.0-dev.20250617/node_modules/@definitelytyped/dtslint/dist/index.js:191:20)

Package: flickity
Error:

Error: 
/mnt/vss/_work/1/DefinitelyTyped/types/flickity/flickity-tests.ts
  101:22  error  TypeScript@local compile error: 
Function declarations are not allowed inside blocks in strict mode when targeting 'ES5'  @definitelytyped/expect
  108:22  error  TypeScript@local compile error: 
Function declarations are not allowed inside blocks in strict mode when targeting 'ES5'  @definitelytyped/expect
  115:22  error  TypeScript@local compile error: 
Function declarations are not allowed inside blocks in strict mode when targeting 'ES5'  @definitelytyped/expect
  122:22  error  TypeScript@local compile error: 
Function declarations are not allowed inside blocks in strict mode when targeting 'ES5'  @definitelytyped/expect
  129:22  error  TypeScript@local compile error: 
Function declarations are not allowed inside blocks in strict mode when targeting 'ES5'  @definitelytyped/expect
  136:22  error  TypeScript@local compile error: 
Function declarations are not allowed inside blocks in strict mode when targeting 'ES5'  @definitelytyped/expect
  143:22  error  TypeScript@local compile error: 
Function declarations are not allowed inside blocks in strict mode when targeting 'ES5'  @definitelytyped/expect
  150:22  error  TypeScript@local compile error: 
Function declarations are not allowed inside blocks in strict mode when targeting 'ES5'  @definitelytyped/expect
  157:22  error  TypeScript@local compile error: 
Function declarations are not allowed inside blocks in strict mode when targeting 'ES5'  @definitelytyped/expect
  164:22  error  TypeScript@local compile error: 
Function declarations are not allowed inside blocks in strict mode when targeting 'ES5'  @definitelytyped/expect
  171:22  error  TypeScript@local compile error: 
Function declarations are not allowed inside blocks in strict mode when targeting 'ES5'  @definitelytyped/expect
  182:22  error  TypeScript@local compile error: 
Function declarations are not allowed inside blocks in strict mode when targeting 'ES5'  @definitelytyped/expect
  189:22  error  TypeScript@local compile error: 
Function declarations are not allowed inside blocks in strict mode when targeting 'ES5'  @definitelytyped/expect
  201:22  error  TypeScript@local compile error: 
Function declarations are not allowed inside blocks in strict mode when targeting 'ES5'  @definitelytyped/expect
  208:22  error  TypeScript@local compile error: 
Function declarations are not allowed inside blocks in strict mode when targeting 'ES5'  @definitelytyped/expect
  215:22  error  TypeScript@local compile error: 
Function declarations are not allowed inside blocks in strict mode when targeting 'ES5'  @definitelytyped/expect
  222:22  error  TypeScript@local compile error: 
Function declarations are not allowed inside blocks in strict mode when targeting 'ES5'  @definitelytyped/expect

✖ 17 problems (17 errors, 0 warnings)

    at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.32_typescript@5.9.0-dev.20250617/node_modules/@definitelytyped/dtslint/dist/index.js:199:28)
    at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.32_typescript@5.9.0-dev.20250617/node_modules/@definitelytyped/dtslint/dist/index.js:191:20)

You can check the log here.

@typescript-bot
Copy link
Collaborator

@jakebailey Here are the results of running the user tests with tsc comparing main and refs/pull/61888/merge:

Everything looks good!

@typescript-bot
Copy link
Collaborator

@jakebailey, the perf run you requested failed. You can check the log here.

@typescript-bot
Copy link
Collaborator

@jakebailey Here are the results of running the top 400 repos with tsc comparing main and refs/pull/61888/merge:

Everything looks good!

@jakebailey
Copy link
Member Author

@typescript-bot test top999

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jun 18, 2025 •
edited
Loading

Starting jobs; this comment will be updated as builds start and complete.

Command Status Results
test top999 ✅ Started 👀 Results

@typescript-bot
Copy link
Collaborator

@jakebailey Here are the results of running the top 999 repos with tsc comparing main and refs/pull/61888/merge:

Something interesting changed - please have a look.

Details

microsoft/SandDance

18 of 26 projects failed to build with the old tsc and were ignored

packages/sanddance-embed/src/gen/tsconfig.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

At least 1 approving review is required to merge this pull request.

Assignees

@jakebailey jakebailey

Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jakebailey @typescript-bot