Skip to content

fix: fix self-loop in workflow #6677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 16, 2025

Conversation

ZenWayne
Copy link
Contributor

@ZenWayne ZenWayne commented Jun 14, 2025

Parent node fetching logic to avoid errors caused by self-referencing edges. New test cases added to verify graph cyclic behavior and termination conditions. Confirmed message order is correct and meets expectations

Why are these changes needed?

self looping in workflow not working

remote self from parent node in Digraph

Related issue number

#6676

Checks

… edges. New test cases added to verify graph cyclic behavior and termination conditions. Confirmed message order is correct and meets expectations
@ZenWayne
Copy link
Contributor Author

@microsoft-github-policy-service agree

@victordibia victordibia requested a review from ekzhu June 14, 2025 19:42
Copy link

codecov bot commented Jun 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.67%. Comparing base (8c1236d) to head (badeb85).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6677   +/-   ##
=======================================
  Coverage   79.67%   79.67%           
=======================================
  Files         231      231           
  Lines       17172    17173    +1     
=======================================
+ Hits        13682    13683    +1     
  Misses       3490     3490           
Flag Coverage Δ
unittests 79.67% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ekzhu
Copy link
Collaborator

ekzhu commented Jun 15, 2025

Thanks for the PR! Could you run the formatter following instructions in python/README.md

@ZenWayne
Copy link
Contributor Author

Sure, I have formatted with poe

@ekzhu ekzhu merged commit cd15c08 into microsoft:main Jun 16, 2025
65 checks passed
ZenWayne added a commit to ZenWayne/autogen that referenced this pull request Jun 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants