-
Notifications
You must be signed in to change notification settings - Fork 7k
Make reflection step work with various openrouter models #6695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@Philipp-Userlike please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
Can you confirm this works for OpenAI endpoint? I hope we can add a general argument |
Why are these changes needed?
This is an attempt to address #5621 and general issues with OpenAI compatible providers and the reflection step.
I had the issue reproduced with both claude and gemini openrouter models and confirmed they can use the reflection step now.
And I think using tool_choice=none is a good idea in general
Related issue number
#5621
Checks