Suggesting test cases for build verification. #10200
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PawelWMS
force-pushed
the
pawelwi/build_test_cases
branch
from
c3e57cd to
3ede89e
Compare
PawelWMS
commented
Aug 23, 2024
Fix invalid config in case 1.
dmcilvaney
reviewed
Oct 23, 2024
| - B absent locally and upstream. | ||
|
|
||
| Expectation: | ||
| - A fails to build due to missing dependency. |
There was a problem hiding this comment.
We could have an option to do a fallback build of "everything" here, but agreed probably best to print a useful error to the user suggesting they trigger the package build manually once.
dmcilvaney
reviewed
Oct 23, 2024
| @@ -0,0 +1,34 @@ | |||
| Dependency on a dynamically-generated provides. Similar to tests suite 2. | |||
There was a problem hiding this comment.
Permutation of test 4+6:
Local copy of A dynamic BRs C
Upstream copy of A is unchanged, but does not list BR C (maybe macro environment changed?)
We have changed C locally
If we have nothing locally, I'd expect us to re-use A and avoid rebuilding
If we have a local copy of the new A, I'd expect us to now rebuild C -> A
This would check if we can learn from previous builds about unexpressed dependencies when doing cache checks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each numbered subfolder is a slightly different scenario with multiple test cases defined in the
Readme.txtfiles.I'm also including a
bogus-generatorspec in case it may come in handy.