Skip to content

Port fasttrack PR check to PRs that target dev branches #10850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 46 commits into from
Jun 18, 2025

Conversation

PawelWMS
Copy link
Contributor

@PawelWMS PawelWMS commented Oct 25, 2024

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

This is porting our FastTrack PR build check into PRs that target dev branches, except they also use daily repo to grab packages from

Change Log
  • Added FastTrack style PR check for used for dev PRs, uses daily repo for packages to be downloaded
  • Moved out common PR check code into template file
Does this affect the toolchain?

NO

Test Methodology

@microsoft-github-policy-service microsoft-github-policy-service bot added Packaging 3.0-dev PRs Destined for AzureLinux 3.0 labels May 20, 2025
@mbykhovtsev-ms mbykhovtsev-ms marked this pull request as ready for review May 31, 2025 00:16
@mbykhovtsev-ms mbykhovtsev-ms requested a review from a team as a code owner May 31, 2025 00:16
@mbykhovtsev-ms mbykhovtsev-ms changed the title TEST DEV PR CHECK Port fasttrack PR check to PRs that target dev branches May 31, 2025
@PawelWMS
Copy link
Contributor Author

@CBL-Mariner-Stable-Maintainers: approved, but it's my own PR, so I can't do it.

@mbykhovtsev-ms mbykhovtsev-ms merged commit 3131fc7 into 3.0-dev Jun 18, 2025
29 checks passed
@mbykhovtsev-ms mbykhovtsev-ms deleted the pawelwi/dev_pr_check branch June 18, 2025 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.0-dev PRs Destined for AzureLinux 3.0 Packaging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants