Upgrade: python-debtcollector version to 3.0.0 #13604
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
Packaging
specs-extended
kgodara912
requested changes
May 5, 2025
| Source0: https://tarballs.openstack.org/%{pypi_name}/%{pypi_name}-%{upstream_version}.tar.gz | ||
| # Required for tarball sources verification | ||
| %if 0%{?sources_gpg} == 1 | ||
| Source101: https://tarballs.openstack.org/%{pypi_name}/%{pypi_name}-%{upstream_version}.tar.gz.asc |
There was a problem hiding this comment.
If possible, please keep the key files into local folder only, both this and below txt file. They are not big and will avoid multiple files for same package.
| done | ||
|
|
||
| # Automatic BR generation | ||
| %generate_buildrequires |
There was a problem hiding this comment.
I am not sure will this work or not. Was this verified and did it correctly generate dependencies for our spec files? If possible, we can directly keep any other build requires. We already have many at the top.
kgodara912
reviewed
May 5, 2025
| BuildRequires: python3-virtualenv | ||
| BuildRequires: python3-sphinx | ||
| BuildRequires: python3-testtools | ||
| BuildRequires: python3-fixtures |
There was a problem hiding this comment.
Please check the names of build requirements. Our extended repo names are without 3, means python-fixtures and not python3-fixtures, similarly check others. Please verify local build once.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-staticsubpackages, etc.) have had theirReleasetag incremented../cgmanifest.json,./toolkit/scripts/toolchain/cgmanifest.json,.github/workflows/cgmanifest.json)./LICENSES-AND-NOTICES/SPECS/data/licenses.json,./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md,./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)*.signatures.jsonfilessudo make go-tidy-allandsudo make go-test-coveragepassSummary
Upgrade: python-debtcollector version to 3.0.0
Change Log
Does this affect the toolchain?
NO
Associated issues
Links to CVEs
Test Methodology