Skip to content

Upgrades lua-lunitx to version 0.8.1 #13629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 13, 2025

Conversation

aninda-al
Copy link
Contributor

@aninda-al aninda-al commented Apr 29, 2025

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

Upgrades lua-lunitx to version 0.8.1

Build/Dependency Information

The PR is a leaf PR which builds alone successfully

Change Log
  • deleted: ../SPECS-EXTENDED/lua-lunit/lua-lunit.signatures.json
  • deleted: ../SPECS-EXTENDED/lua-lunit/lua-lunit.spec
  • new file: ../SPECS-EXTENDED/lua-lunitx/lua-lunitx.signatures.json
  • new file: ../SPECS-EXTENDED/lua-lunitx/lua-lunitx.spec
  • modified: ../cgmanifest.json
  • modified: ../LICENSES-AND-NOTICES/SPECS/data/licenses.json
  • modified: LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md
Does this affect the toolchain?

NO

Associated issues
  • NA
Links to CVEs
  • NA
Test Methodology
  • NA

@aninda-al aninda-al requested review from a team as code owners April 29, 2025 16:54
@microsoft-github-policy-service microsoft-github-policy-service bot added Packaging specs-extended PR to fix SPECS-EXTENDED 3.0-dev PRs Destined for AzureLinux 3.0 labels Apr 29, 2025
@aninda-al aninda-al force-pushed the upgrade-lua-lunitx branch 2 times, most recently from fa7ab17 to 08d39e3 Compare April 29, 2025 21:25
Copy link
Contributor

@kgodara912 kgodara912 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Buddy build passes. LGTM with minor suggesion.

BuildArch: noarch

Provides: lua-lunit = %{version}-%{release}
Obsoletes: lua-lunit <= 0.5-18
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may obsolete any version < 0.8.1-12? Also, instead of hard coding, we can put < %{version}-%{release}
like the line above it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

modified obsoletes comparison as suggested

@0xba1a
Copy link
Contributor

0xba1a commented May 5, 2025

@aninda-al There are many other files other than lua-lunitx are updated in this PR. Is it intended?

@kgodara912 Please review the PR once again as there are changes after your approval.

@aninda-al
Copy link
Contributor Author

@0xba1a Those extra files were merged by mistake. This pkg is actually renamed and each time I update it, there merge conflict and looks like I messed up during resolving the merge conflicts.

@aninda-al aninda-al force-pushed the upgrade-lua-lunitx branch 2 times, most recently from 57edb3a to 08d39e3 Compare May 5, 2025 18:14
@aninda-al aninda-al force-pushed the upgrade-lua-lunitx branch from 08d39e3 to a3a699e Compare May 5, 2025 18:18
@0xba1a
Copy link
Contributor

0xba1a commented May 6, 2025

@aninda-al Can you get reviewed by @kgodara912 once again for the new changes?

Copy link
Contributor

@kgodara912 kgodara912 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Buddy build. Once conflicts are resolved which will be most likely in license files, should be good to merge.

Copy link
Contributor

@0xba1a 0xba1a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lua-lunit is not maintained anymore. lua-lunitx is an extended version of the original package. This is also very dormant without any updates in last 7 years. We keep it as it is a BR for lua-json. This package looks safe as it is being built regularly in each Fedora release and no active CVEs.

@0xba1a 0xba1a merged commit 0a14c4e into microsoft:3.0-dev May 13, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.0-dev PRs Destined for AzureLinux 3.0 Packaging specs-extended PR to fix SPECS-EXTENDED Tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants