-
Notifications
You must be signed in to change notification settings - Fork 580
Upgrades lua-lunitx to version 0.8.1 #13629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fa7ab17
to
08d39e3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Buddy build passes. LGTM with minor suggesion.
BuildArch: noarch | ||
|
||
Provides: lua-lunit = %{version}-%{release} | ||
Obsoletes: lua-lunit <= 0.5-18 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You may obsolete any version < 0.8.1-12? Also, instead of hard coding, we can put < %{version}-%{release}
like the line above it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
modified obsoletes comparison as suggested
@aninda-al There are many other files other than @kgodara912 Please review the PR once again as there are changes after your approval. |
@0xba1a Those extra files were merged by mistake. This pkg is actually renamed and each time I update it, there merge conflict and looks like I messed up during resolving the merge conflicts. |
57edb3a
to
08d39e3
Compare
08d39e3
to
a3a699e
Compare
@aninda-al Can you get reviewed by @kgodara912 once again for the new changes? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Buddy build. Once conflicts are resolved which will be most likely in license files, should be good to merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lua-lunit is not maintained anymore. lua-lunitx is an extended version of the original package. This is also very dormant without any updates in last 7 years. We keep it as it is a BR for lua-json
. This package looks safe as it is being built regularly in each Fedora release and no active CVEs.
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-static
subpackages, etc.) have had theirRelease
tag incremented../cgmanifest.json
,./toolkit/scripts/toolchain/cgmanifest.json
,.github/workflows/cgmanifest.json
)./LICENSES-AND-NOTICES/SPECS/data/licenses.json
,./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md
,./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON
)*.signatures.json
filessudo make go-tidy-all
andsudo make go-test-coverage
passSummary
Upgrades lua-lunitx to version 0.8.1
Build/Dependency Information
The PR is a leaf PR which builds alone successfully
Change Log
Does this affect the toolchain?
NO
Associated issues
Links to CVEs
Test Methodology