-
Notifications
You must be signed in to change notification settings - Fork 580
[MEDIUM] Patch pytorch for CVE-2025-2953 #13642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The upstream reference has a test case for the scenario exploited to avoid future occurrences of the issue. Any reason for omitting that as we have the test file present in Azure Linux distribution?
I had verified the rpm contents to see that we donot ship test_mkldnn.py in Azure Linux Also, Astrolabe's deepscan results doesn't show the scan results for test file. |
That is correct that we do not ship the test files, but we do test internally by running %check section in our spec files. The purpose of test file changes is to ensure that tomorrow someone should not change the same code and introduce issue again. Test files are there for correctness of source code and not for shipments. Please include test files for better testing coverage. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Buddy build. It seems that patch doesn't apply cleanly on 2.0 dev branch. Please check if the test file change is trivial to fix, else we can revert back to original patch for CVE fix for 2.0-dev.
time="2025-05-12T15:40:48Z" level=debug msg="+ /usr/lib/rpm/rpmuncompress /usr/src/mariner/SOURCES/CVE-2025-2953.patch"
time="2025-05-12T15:40:48Z" level=debug msg="+ /bin/patch -p1 -s --fuzz=0 --no-backup-if-mismatch -f"
time="2025-05-12T15:40:48Z" level=debug msg="1 out of 1 hunk FAILED -- saving rejects to file test/test_mkldnn.py.rej"
6c66598
to
8e58df5
Compare
Modified patch. Please verify |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Buddy build. The patch matches with reference patch. LGTM.
|
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-static
subpackages, etc.) have had theirRelease
tag incremented../cgmanifest.json
,./toolkit/scripts/toolchain/cgmanifest.json
,.github/workflows/cgmanifest.json
)./LICENSES-AND-NOTICES/SPECS/data/licenses.json
,./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md
,./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON
)*.signatures.json
filessudo make go-tidy-all
andsudo make go-test-coverage
passSummary
What does the PR accomplish, why was it needed?
Patch pytorch for CVE-2025-2953
Change Log
Does this affect the toolchain?
NO
Associated issues
Links to CVEs
Test Methodology