Add new package citus for work item 47499297 #13653
Conversation
microsoft-github-policy-service
bot
added
Packaging
3.0-dev
cyberbandya007
force-pushed
the
skarambelkar/citus-addition-1
branch
from
07293b3 to
d93e23d
Compare
| Patch0: disable_unwanted_tests.patch | ||
| %endif | ||
| URL: https://github.com/citusdata/%{name} | ||
| BuildRequires: postgresql-devel |
There was a problem hiding this comment.
Many spec files put make and gcc in BuildRequires, do we need to put here explicitly for some environments to make this spec file work in those environments?
|
|
||
| %build | ||
| currentgccver="$(gcc -dumpversion)" | ||
| requiredgccver="4.8.2" |
There was a problem hiding this comment.
Should we put it as requiredmingccver for better communication?
| %install | ||
| %make_install | ||
| # Install documentation with a better name: | ||
| %{__mkdir} -p %{buildroot}%{_docdir}/postgresql/extension |
There was a problem hiding this comment.
Is there any difference between this and below mkdir? If not, then we can make them uniform.
| %doc %{_docdir}/postgresql/extension/NOTICE-%{name} | ||
|
|
||
| %changelog | ||
| * Mon Apr 29 2025 Sandeep Karambelkar <skarambelkar@microsoft.com> - 13.0.3-1 |
| @@ -0,0 +1,86 @@ | |||
| Summary: PostgreSQL-based distributed RDBMS | |||
| Name: citus | |||
| Conflicts: %{name} | |||
There was a problem hiding this comment.
Check if we can put version number (something like < %{Version}) if the package conflicts with itself..
| @@ -0,0 +1,86 @@ | |||
| Summary: PostgreSQL-based distributed RDBMS | |||
There was a problem hiding this comment.
Is there a reason we didn't start with the .spec available upstream?
https://github.com/citusdata/packaging/blob/all-citus/citus.spec
There was a problem hiding this comment.
We did use the same spec and fixed it for azure linux.
LeoMar4
changed the title
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-staticsubpackages, etc.) have had theirReleasetag incremented../cgmanifest.json,./toolkit/scripts/toolchain/cgmanifest.json,.github/workflows/cgmanifest.json)./LICENSES-AND-NOTICES/SPECS/data/licenses.json,./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md,./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)*.signatures.jsonfilessudo make go-tidy-allandsudo make go-test-coveragepassSummary
Adds new package citus for work item 47499297
Change Log
Does this affect the toolchain?
NO
Test Methodology