Skip to content

Removed apache-commons-lang package from SPECS-EXTENDED #13716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: 3.0-dev
Choose a base branch
from

Conversation

durgajagadeesh
Copy link
Contributor

@durgajagadeesh durgajagadeesh commented May 8, 2025

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary
  • Removed apache-commons-lang package from SPECS-EXTENDED
Change Log
  • Bump up the version
  • License verified
Does this affect the toolchain?

NO

Associated issues
  • #xxxx
Links to CVEs
Test Methodology
  • Pipeline build id: xxxx

@durgajagadeesh durgajagadeesh requested a review from a team as a code owner May 8, 2025 15:46
@microsoft-github-policy-service microsoft-github-policy-service bot added Packaging specs-extended PR to fix SPECS-EXTENDED 3.0-dev PRs Destined for AzureLinux 3.0 labels May 8, 2025
@durgajagadeesh durgajagadeesh force-pushed the topic_apache-commons-lang branch from 089d802 to 2a8fe97 Compare May 8, 2025 21:05
@durgajagadeesh durgajagadeesh requested a review from a team as a code owner May 8, 2025 21:05
@durgajagadeesh
Copy link
Contributor Author

Subject: Issue with Package Build Due to Java Version Compatibility
Hi,
This package is encountering a Java version error and fails during the build process due to unsupported source code.

I attempted to upgrade the version from Fedora 41, but the upstream appears to be unmaintained.

I noticed that this package (apache-commons-lang) has already been upgraded in the core (SPEC) under the name apache-commons-lang3.

After thorough research, I found that no other package depends on apache-commons-lang.

Note: I did find one package (hawtjni) referencing apache-commons-lang; however, this has already been resolved using apache-commons-lang3.

Thank you.

Copy link
Contributor

@kgodara912 kgodara912 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seems one more, core package conditionally depends on this extended package, did you check?

../SPECS/thrift/thrift.spec:217:BuildRequires: apache-commons-lang

Though it is under %if 0%{?want_java} > 0 but if someone want to build it, that shouldn't break.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.0-dev PRs Destined for AzureLinux 3.0 Packaging specs-extended PR to fix SPECS-EXTENDED
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants