Skip to content

Add libxcrypt-devel to build-essential #13757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 3.0-dev
Choose a base branch
from

Conversation

kgodara912
Copy link
Contributor

@kgodara912 kgodara912 commented May 12, 2025

libcrypt was removed from glibc-2.38. This change adds libxcrypt-devel to build-essential for crypto header support.

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

This PR adds libcrypt-devel to build-essential

Change Log
  • Added libcrypt-devel to build-essential
Does this affect the toolchain?

NO

Associated issues
Links to CVEs
Test Methodology

libcrypt was removed from glibc-2.38. This change adds libxcrypt to
build-essential for crypto header support.
@microsoft-github-policy-service microsoft-github-policy-service bot added Packaging 3.0-dev PRs Destined for AzureLinux 3.0 labels May 12, 2025
@kgodara912 kgodara912 changed the title Adding libxcrypt-devel to build-essential Add libxcrypt-devel to build-essential May 12, 2025
@kgodara912 kgodara912 marked this pull request as ready for review May 12, 2025 08:54
@kgodara912 kgodara912 requested a review from a team as a code owner May 12, 2025 08:54
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds the libxcrypt-devel dependency to the build-essential metapackage to support crypto header functionality after libcrypt was removed from glibc-2.38.

  • Updated the Release tag from 3 to 4
  • Added libxcrypt-devel to the list of required packages
  • Updated the changelog to reflect the changes

@0xba1a
Copy link
Contributor

0xba1a commented May 20, 2025

@kgodara912 @Kanishk-Bansal Do we have stable-shiproom approval for this change?

@0xba1a 0xba1a requested a review from Kanishk-Bansal May 20, 2025 15:00
@Kanishk-Bansal
Copy link
Contributor

@kgodara912 @Kanishk-Bansal Do we have stable-shiproom approval for this change?

Not yet, waiting for one signoff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.0-dev PRs Destined for AzureLinux 3.0 Packaging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants