-
Notifications
You must be signed in to change notification settings - Fork 580
[Medium] Upgrade ruby to 3.1.7 to fix CVE-2024-39908 #13764
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Medium] Upgrade ruby to 3.1.7 to fix CVE-2024-39908 #13764
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At this stage of project, major version upgrade may cause stability issues. It is better to check once the minor version release notes corresponding to ruby-3.1.7 and see if that is good enough to fix the CVE.
I was going off of the triage notes: |
This CVE affects REXML gem 3.3.1 or prior Nice finding @kgodara912 |
Ok, I'll pivot and update to |
Also remove obsolete patches, edit one patch to remove changes made redundant by the upgrade
7724e46
to
724902d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove all #Patch in SPECS
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Buddy build. Minor version upgrade for ruby. Please correct above PR description with proper CVE numbers and what patches removed correctly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor version upgrade. The one, non-removed patch, is upgraded with following upstream references,
https://github.com/ruby/uri/commit/9010ee2536adda10a0555ae1ed6fe2f5808e6bf1
https://github.com/ruby/uri/commit/9d7bcef1e6ad23c9c6e4932f297fb737888144c8
Buddy build is fine. LGTM.
@@ -82,8 +82,8 @@ Name: ruby | |||
# TODO: When changing ruby version, these gemified stdlib | |||
# provides should be versioned according to the ruby version. | |||
# More info: https://stdgems.org/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check the above versions specified, do they also need new numbers based on the new ruby version? For e.g. is zlib_version 2.1.1
still valid or it needs upgraded number, similarly for others as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe these are correct, I ran the get_gem_versions.sh
script and didn't see a change, but I can run it again and double check if you wish.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as developer verified that bundled versions are correct.
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-static
subpackages, etc.) have had theirRelease
tag incremented../cgmanifest.json
,./toolkit/scripts/toolchain/cgmanifest.json
,.github/workflows/cgmanifest.json
)./SPECS/LICENSES-AND-NOTICES/data/licenses.json
,./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md
,./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON
)*.signatures.json
filessudo make go-tidy-all
andsudo make go-test-coverage
passSummary
Upgrade
ruby
to3.3.2
to fix CVE-2024-39908Also delete obsolete or irrelevant patches
This is my first time upgrading
ruby
, please let me know if there's somethingI messed up or missed.
Change Log
Does this affect the toolchain?
NO
Links to CVEs
Test Methodology