Skip to content

Adding missing package double-conversion #13836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: 3.0-dev
Choose a base branch
from

Conversation

AZaugg
Copy link
Contributor

@AZaugg AZaugg commented May 20, 2025

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

Package double-conversion is missing in azl3 but available in mariner2

Change Log
  • Added a new package
Does this affect the toolchain?

YES/NO

Associated issues
  • #xxxx
Links to CVEs
Test Methodology
  • Pipeline build id: xxxx

@AZaugg AZaugg requested a review from a team as a code owner May 20, 2025 20:22
@microsoft-github-policy-service microsoft-github-policy-service bot added Packaging 3.0-dev PRs Destined for AzureLinux 3.0 labels May 20, 2025
AZaugg and others added 3 commits May 21, 2025 15:12
Package double-conversion is missing in azl3 but available in mariner2
Co-authored-by: Muhammad Falak R Wani <falakreyaz@gmail.com>
@AZaugg AZaugg force-pushed the 3.0-pkg-add-double-conversion branch from d15e5af to 7e37b12 Compare May 21, 2025 15:15
@AZaugg
Copy link
Contributor Author

AZaugg commented May 21, 2025

@christopherco christopherco requested a review from Copilot May 29, 2025 07:57
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Add support for the missing double-conversion package across manifests, SPECs, signatures, and license mappings

  • Introduce component metadata for double-conversion in cgmanifest.json
  • Add a new RPM SPEC and signature file for version 3.1.5
  • Update license data and mapping to include the new package

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
cgmanifest.json Added a new “double-conversion” component entry
SPECS/double-conversion/double-conversion.spec Created SPEC file for building version 3.1.5
SPECS/double-conversion/double-conversion.signatures.json Added checksum signature for the source archive
LICENSES-AND-NOTICES/SPECS/data/licenses.json Inserted “double-conversion” into the license list
LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md Updated the Fedora license map row to include it
Comments suppressed due to low confidence (2)

LICENSES-AND-NOTICES/SPECS/data/licenses.json:190

  • Replace tab characters with spaces to match the file's existing indentation style and maintain consistency.
\t\t"double-conversion",

LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md:8

  • [nitpick] The Fedora row is extremely long—consider breaking the package list into multiple lines or grouping alphabetically to improve readability and future updates.
| Fedora | [Fedora MIT License Declaration](https://fedora...) | ... dotconf <br> double-conversion <br> dovecot ... |

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.0-dev PRs Destined for AzureLinux 3.0 Packaging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants