-
Notifications
You must be signed in to change notification settings - Fork 583
Adding missing package double-conversion #13836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 3.0-dev
Are you sure you want to change the base?
Conversation
Package double-conversion is missing in azl3 but available in mariner2
Co-authored-by: Muhammad Falak R Wani <falakreyaz@gmail.com>
d15e5af
to
7e37b12
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Add support for the missing double-conversion package across manifests, SPECs, signatures, and license mappings
- Introduce component metadata for double-conversion in
cgmanifest.json
- Add a new RPM SPEC and signature file for version 3.1.5
- Update license data and mapping to include the new package
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
cgmanifest.json | Added a new “double-conversion” component entry |
SPECS/double-conversion/double-conversion.spec | Created SPEC file for building version 3.1.5 |
SPECS/double-conversion/double-conversion.signatures.json | Added checksum signature for the source archive |
LICENSES-AND-NOTICES/SPECS/data/licenses.json | Inserted “double-conversion” into the license list |
LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md | Updated the Fedora license map row to include it |
Comments suppressed due to low confidence (2)
LICENSES-AND-NOTICES/SPECS/data/licenses.json:190
- Replace tab characters with spaces to match the file's existing indentation style and maintain consistency.
\t\t"double-conversion",
LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md:8
- [nitpick] The Fedora row is extremely long—consider breaking the package list into multiple lines or grouping alphabetically to improve readability and future updates.
| Fedora | [Fedora MIT License Declaration](https://fedora...) | ... dotconf <br> double-conversion <br> dovecot ... |
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-static
subpackages, etc.) have had theirRelease
tag incremented../cgmanifest.json
,./toolkit/scripts/toolchain/cgmanifest.json
,.github/workflows/cgmanifest.json
)./LICENSES-AND-NOTICES/SPECS/data/licenses.json
,./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md
,./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON
)*.signatures.json
filessudo make go-tidy-all
andsudo make go-test-coverage
passSummary
Package double-conversion is missing in azl3 but available in mariner2
Change Log
Does this affect the toolchain?
YES/NO
Associated issues
Links to CVEs
Test Methodology