Skip to content

[Medium] Patch systemd & systemd-bootstrap for CVE-2023-7008 #13866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 16, 2025

Conversation

akhila-guruju
Copy link
Contributor

@akhila-guruju akhila-guruju commented May 22, 2025

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

Patch systemd & systemd-bootstrap for CVE-2023-7008

Change Log
  • new file: SPECS/systemd/CVE-2023-7008.patch
  • modified: SPECS/systemd/systemd.spec
  • modified: SPECS/systemd/fix-journald-audit-logging.patch
Does this affect the toolchain?

YES

Associated issues
  • #xxxx
Links to CVEs
Test Methodology
  • Pipeline build id: xxxx

@akhila-guruju akhila-guruju requested a review from a team as a code owner May 22, 2025 13:32
@akhila-guruju
Copy link
Contributor Author

Regarding fix-journald-audit-logging.patch : A small modification has been done for this patch. Extra space was removed because it resulted in improper patch application as "Patch unexpectedly ends in middle of line". When I removed that extra space, the patch applied cleanly.
systemd-Patch0-cp

Copy link
Contributor

@Kanishk-Bansal Kanishk-Bansal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Patch applies cleanly.
Buddy Build

@Kanishk-Bansal
Copy link
Contributor

  • patch applied during the build (check rpm.log)
  • patch include an upstream reference
  • PR has security tag

@Kanishk-Bansal
Copy link
Contributor

systemd ptest is failing since long

@kgodara912 kgodara912 requested a review from a team May 23, 2025 08:02
@akhila-guruju akhila-guruju changed the title [Medium] Patch systemd for CVE-2023-7008 [Medium] Patch systemd & systemd-bootstrap for CVE-2023-7008 Jun 5, 2025
@0xba1a
Copy link
Contributor

0xba1a commented Jun 13, 2025

@akhila-guruju We need full-build results as this PR touches bootstrap package too. Please co-ordinate with any of the reviewers to trigger the full-build.

@dmcilvaney Can you please verify the full-build for proper building of systemd-bootstrap package and the final systemd getting built with the newly built bootstrap package once it is triggered by @akhila-guruju ?

@0xba1a 0xba1a requested a review from dmcilvaney June 13, 2025 07:34
@Kanishk-Bansal
Copy link
Contributor

Kanishk-Bansal commented Jun 13, 2025

Full Build passes, we can keep the PR going

Copy link
Contributor

@dmcilvaney dmcilvaney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Toolchain did use the new systmed-bootstrap

@0xba1a 0xba1a merged commit af38d38 into microsoft:main Jun 16, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
main PR Destined for main Packaging security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants