Skip to content

[MEDIUM] patch cmake for CVE-2025-4947 #13959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 18, 2025

Conversation

durgajagadeesh
Copy link
Contributor

@durgajagadeesh durgajagadeesh commented Jun 4, 2025

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary
Change Log
  • Bump up the release number by 1
  • modified: SPECS/cmake/cmake.spec
  • added: SPECS/cmake/CVE-2025-4947.patch
Does this affect the toolchain?

NO

Associated issues
  • #xxxx
Links to CVEs
Test Methodology
  • Verified patches are applied

image

@durgajagadeesh durgajagadeesh requested a review from a team as a code owner June 4, 2025 18:14
@microsoft-github-policy-service microsoft-github-policy-service bot added Packaging 3.0-dev PRs Destined for AzureLinux 3.0 labels Jun 4, 2025
@durgajagadeesh durgajagadeesh marked this pull request as draft June 4, 2025 18:39
@durgajagadeesh durgajagadeesh marked this pull request as ready for review June 5, 2025 05:43
@durgajagadeesh durgajagadeesh marked this pull request as draft June 5, 2025 05:51
@durgajagadeesh durgajagadeesh marked this pull request as ready for review June 9, 2025 16:18
Copy link
Contributor

@suresh-thelkar suresh-thelkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good to me. Can you please attach the buddy build results.

@durgajagadeesh
Copy link
Contributor Author

durgajagadeesh commented Jun 10, 2025

Code changes look good to me. Can you please attach the buddy build results.

Hi @suresh-thelkar,
I have successfully tested both the installation and uninstallation of the cmake-3.30.3-7 package.
Installtion:
image
image

Log file from Local VM:
Uploading cmake-3.30.3-7.azl3.src.rpm.log…

Thank you!

@durgajagadeesh
Copy link
Contributor Author

durgajagadeesh commented Jun 10, 2025

Hi,
This patch is applied successfully and built fine in my local VM as shown in build log.
image

Thank you!

@durgajagadeesh
Copy link
Contributor Author

durgajagadeesh commented Jun 10, 2025

Buddy build link
Build fails with DAILY_BUILD_ID.

@kgodara912
Copy link
Contributor

Buddy build

@durgajagadeesh
Copy link
Contributor Author

Buddy build

Hi @kgodara912,
This build is okay,
Thanks!

Copy link
Contributor

@Kanishk-Bansal Kanishk-Bansal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Buddy Build
  • patch applied during the build (check rpm.log)
  • patch include an upstream reference
  • PR has security tag

@0xba1a
Copy link
Contributor

0xba1a commented Jun 16, 2025

@durgajagadeesh @Kanishk-Bansal @suresh-thelkar Toolchain change require full-build.

Copy link
Contributor

@suresh-thelkar suresh-thelkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good to me. As Bala mentioned please make sure that you run full build and verify all the results.

@Kanishk-Bansal
Copy link
Contributor

Full Build

@0xba1a
Copy link
Contributor

0xba1a commented Jun 17, 2025

Full Build

Waiting for full build

@0xba1a 0xba1a merged commit 61022e4 into microsoft:3.0-dev Jun 18, 2025
24 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.0-dev PRs Destined for AzureLinux 3.0 Packaging security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants