Skip to content

[MEDIUM] Patch glib for CVE-2025-4373 #13978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

aninda-al
Copy link
Contributor

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

Address CVE-2025-4373

Upstream Patch Applies Cleanly: https://gitlab.gnome.org/GNOME/glib/-/merge_requests/4588.patch
Patch commit in astrolabe: https://gitlab.gnome.org/GNOME/glib/-/merge_requests/4588/diffs?commit_id=cc647f9e46d55509a93498af19659baf9c80f2e3

Also checked local build log file to ensure patch applied cleanly.

Change Log
  • modified: ../SPECS/glib/glib.spec
  • modified: resources/manifests/package/pkggen_core_aarch64.txt
  • modified: resources/manifests/package/pkggen_core_x86_64.txt
  • modified: resources/manifests/package/toolchain_aarch64.txt
  • modified: resources/manifests/package/toolchain_x86_64.txt
  • added: ../SPECS/glib/CVE-2025-4373.patch
Does this affect the toolchain?

YES

Associated issues
  • #NA
Links to CVEs
Test Methodology
  • local build
  • Needs toolchain rebuild as glib is part of toolchain

@aninda-al aninda-al marked this pull request as ready for review June 10, 2025 10:44
@aninda-al aninda-al requested a review from a team as a code owner June 10, 2025 10:44
Copy link
Contributor

@Kanishk-Bansal Kanishk-Bansal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Buddy Build
  • patch applied during the build (check rpm.log)
  • patch include an upstream reference
  • PR has security tag

@Kanishk-Bansal
Copy link
Contributor

Upstream Patch Applies Cleanly. LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
main PR Destined for main Packaging security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants