-
Notifications
You must be signed in to change notification settings - Fork 587
Update toolkit go version to 1.23, update dependency install scripts, add install-prereqs-and-configure target #13991
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… documentation for local vs pipeline setup
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR bumps the Go version in the toolkit to 1.23.1 and updates associated dependency versions and installation scripts to reflect the new toolchain requirements. Key changes include:
- Updating go.mod to use Go 1.23.0 and adjusting dependency versions (e.g., gonum from v0.15.0 to v0.16.0).
- Enhancing the make targets in scripts (tools.mk and toolkit.mk) to provide improved warning instructions and adding the new install-prereqs-and-configure target.
- Revising the prerequisite scripts and documentation for both Ubuntu and Mariner to support the new Go version and additional configuration options.
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
toolkit/tools/go.mod | Updated Go version and dependencies |
toolkit/scripts/tools.mk | Modified warning/error flow for Go version checks |
toolkit/scripts/toolkit.mk | Added new make target (install-prereqs-and-configure) and refined OS logic |
toolkit/docs/building/prerequisites-ubuntu.sh | Updated package name for Go and added command-line options |
toolkit/docs/building/prerequisites-ubuntu.md | Updated installation instructions and command options |
toolkit/docs/building/prerequisites-mariner.sh | Revised script options, including support for msft-golang |
toolkit/docs/building/prerequisites-mariner.md | Updated documentation to reflect Mariner-specific prerequisites |
.github/workflows/go-test-coverage.yml | Updated the expected Go version to 1.23 |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Supersedes:
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-static
subpackages, etc.) have had theirRelease
tag incremented../cgmanifest.json
,./toolkit/scripts/toolchain/cgmanifest.json
,.github/workflows/cgmanifest.json
)./LICENSES-AND-NOTICES/SPECS/data/licenses.json
,./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md
,./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON
)*.signatures.json
filessudo make go-tidy-all
andsudo make go-test-coverage
passSummary
What does the PR accomplish, why was it needed?
Bump golang version in toolkit to 1.23. Additionally, update prerequisite scripts and docs to include the new flow of
sudo make install-prereqs
andsudo make install-prereqs-and-configure
.Change Log
Does this affect the toolchain?
NO
Associated issues
Links to CVEs
Test Methodology
sudo make install-prereqs-and-configure
->sudo reboot
sudo make build-packages DAILY_BUILD_ID=lkg REBUILD_TOOLS=y SRPM_PACK_LIST=words PACKAGE_REBUILD_LIST=words -j100
sudo make install-prereqs-and-configure
->sudo reboot
sudo make install-prereqs-and-configure
->sudo reboot
Additional tests
make install-prereqs
make install-prereqs