Skip to content

Patch frr for CVE-2024-55553 [High] #13999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 13, 2025

Conversation

Kanishk-Bansal
Copy link
Contributor

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

What does the PR accomplish, why was it needed?

Patch Summary

Removes "revalidate all routes" logic and associated thread fields.
Changes bgpd_sync_callback to only revalidate affected prefixes, not all routes.
Removes is_stopping() static function in favor of direct access to the rtr_is_stopping field.
Removes t_revalidate_all from peer struct and related thread logic.
Introduces revalidate_single_prefix.
Cleans up memory and thread handling accordingly.

Change Log
Does this affect the toolchain?

YES

Associated issues
  • #xxxx
Links to CVEs
Test Methodology

Signed-off-by: Kanishk Bansal <kanbansal@microsoft.com>
@Kanishk-Bansal Kanishk-Bansal requested a review from a team as a code owner June 13, 2025 12:39
@microsoft-github-policy-service microsoft-github-policy-service bot added Packaging fasttrack/2.0 PRs Destined for Azure Linux 2.0 labels Jun 13, 2025
@Kanishk-Bansal
Copy link
Contributor Author

This backport was possible as the frr maintainer released a backport for 8.4 at opensourcerouting/frr@cc1c66a

Copy link

@aaruag aaruag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aaruag aaruag added the CVEFixReadyForMaintainerReview When a CVE fix has been reviewed by release manager and is ready for stable maintainer review label Jun 13, 2025
@jslobodzian jslobodzian merged commit 434f40d into fasttrack/2.0 Jun 13, 2025
26 checks passed
@jslobodzian jslobodzian deleted the kanbansal/frr/CVE-2024-55553/2.0 branch June 13, 2025 18:58
CBL-Mariner-Bot pushed a commit that referenced this pull request Jun 13, 2025
Signed-off-by: Kanishk Bansal <kanbansal@microsoft.com>
Co-authored-by: Kanishk Bansal <kanbansal@microsoft.com>
(cherry picked from commit 434f40d)
@CBL-Mariner-Bot
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CVEFixReadyForMaintainerReview When a CVE fix has been reviewed by release manager and is ready for stable maintainer review fasttrack/2.0 PRs Destined for Azure Linux 2.0 Packaging security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants