Skip to content

[Medium] patch qt5-qtbase for CVE-2025-30348 #14007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Medium] patch qt5-qtbase for CVE-2025-30348 #14007

wants to merge 1 commit into from

Conversation

jykanase
Copy link
Contributor

@jykanase jykanase commented Jun 15, 2025 •
edited
Loading

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge
Summary

patch qt5-qtbase for CVE-2025-30348
Modified Patch: Yes

Change Log
Does this affect the toolchain?

NO

Associated issues
  • #xxxx
Links to CVEs
Test Methodology

-Verifed patch is apllied.
image

@jykanase jykanase requested a review from a team as a code owner June 15, 2025 13:03
@jykanase jykanase marked this pull request as draft June 16, 2025 07:57
@jykanase jykanase marked this pull request as ready for review June 16, 2025 08:40
mfrw
mfrw approved these changes Jun 16, 2025
View reviewed changes
Copy link
Member

@mfrw mfrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

SPECS/qt5-qtbase/CVE-2025-30348.patch
Date: Fri, 13 Jun 2025 14:00:19 +0000
Subject: [PATCH] CVE-2025-30348.patch

Upstream Patch Reference: https://codereview.qt-project.org/c/qt/qtbase/+/581442/1/src/xml/dom/qdom.cpp#3643
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Patch looks good w.r.t upstream

@jykanase jykanase force-pushed the topic_qt5-qtbase-2.0 branch 2 times, most recently from 258f273 to e362527 Compare June 19, 2025 04:57
@jykanase jykanase force-pushed the topic_qt5-qtbase-2.0 branch from e362527 to d1bd14d Compare June 19, 2025 05:17
Kanishk-Bansal
Kanishk-Bansal approved these changes Jun 19, 2025
View reviewed changes
Copy link
Contributor

@Kanishk-Bansal Kanishk-Bansal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Buddy Build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfrw mfrw mfrw approved these changes

@Kanishk-Bansal Kanishk-Bansal Kanishk-Bansal approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
main PR Destined for main Packaging security
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jykanase @mfrw @Kanishk-Bansal