Skip to content

Upgrade wireshark to 4.4.7 and fix build issues #14008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 17, 2025
Merged

Upgrade wireshark to 4.4.7 and fix build issues #14008

merged 6 commits into from
Jun 17, 2025

Conversation

cyberbandya007
Copy link
Contributor

@cyberbandya007 cyberbandya007 commented Jun 16, 2025 •
edited
Loading

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge
Summary

Upgrade wireshark to 4.4.7 and fix build issues

Change Log
  • Upgraded wireshark to 4.4.7
  • Fix Build Issues
Does this affect the toolchain?

NO

Test Methodology
  • Pipeline build id: Buddy Build - 837876

@cyberbandya007 cyberbandya007 requested review from a team as code owners June 16, 2025 09:04
@microsoft-github-policy-service microsoft-github-policy-service bot added Packaging specs-extended PR to fix SPECS-EXTENDED 3.0 PRs Destined for 3.0 labels Jun 16, 2025
@cyberbandya007 cyberbandya007 changed the base branch from 3.0 to 3.0-dev June 16, 2025 09:16
@microsoft-github-policy-service microsoft-github-policy-service bot added the 3.0-dev PRs Destined for AzureLinux 3.0 label Jun 16, 2025
cyberbandya007
cyberbandya007 commented Jun 16, 2025
View reviewed changes
SPECS-EXTENDED/wireshark/wireshark-01-pkgconfig.patch
@@ -0,0 +1,13 @@
diff --git a/CMakeLists.txt b/CMakeLists.txt
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Patch reference - Fedora 42
https://src.fedoraproject.org/rpms/wireshark/blob/f42/f/wireshark-0008-pkgconfig.patch

@cyberbandya007
Copy link
Contributor Author

OLD PR ref - #13257

@0xba1a 0xba1a merged commit e5387c7 into 3.0-dev Jun 17, 2025
17 checks passed
@0xba1a 0xba1a deleted the skarambelkar/wireshark/3.0-dev branch June 17, 2025 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xba1a 0xba1a 0xba1a approved these changes

@mfrw mfrw mfrw approved these changes

Assignees
No one assigned
Labels
3.0-dev PRs Destined for AzureLinux 3.0 3.0 PRs Destined for 3.0 Packaging specs-extended PR to fix SPECS-EXTENDED
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cyberbandya007 @0xba1a @mfrw