Skip to content

[Medium] Patch systemd for CVE-2025-4598 #14009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

akhila-guruju
Copy link
Contributor

@akhila-guruju akhila-guruju commented Jun 16, 2025

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

Patch systemd for CVE-2025-4598

  • Patch Modified: Yes
  • The fix for this vulnerability is twofold: (Reference)
  1. systemd/systemd-stable@2eb46dc
  2. systemd/systemd@fc79431
Change Log
  • new file: SPECS/systemd/CVE-2025-4598.patch
  • new file: 0001-Prerequisite-for-CVE-2025-4598.patch
  • modified: SPECS/systemd/systemd.spec
Does this affect the toolchain?

NO

Associated issues
  • #xxxx
Links to CVEs
Test Methodology
image

@akhila-guruju akhila-guruju requested a review from a team as a code owner June 16, 2025 10:21
@akhila-guruju akhila-guruju marked this pull request as draft June 16, 2025 10:26
@akhila-guruju akhila-guruju marked this pull request as ready for review June 16, 2025 11:32
@akhila-guruju akhila-guruju reopened this Jun 16, 2025
@Malateshk007 Malateshk007 requested a review from a team June 17, 2025 06:58
Copy link
Member

@mfrw mfrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we please take a look at the tests.

Copy link
Member

@mfrw mfrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Retriggered Buddy Build: link

@akhila-guruju akhila-guruju marked this pull request as draft June 25, 2025 05:07
@akhila-guruju
Copy link
Contributor Author

akhila-guruju commented Jun 30, 2025

I'm updating the patch by adding %F specifier to address the bug, following the latest triage comment from Astrolabe. The backport is required. systemd is building with updated patch, but there's one additional ptest failing. I am working on resolving this issue.

@akhila-guruju akhila-guruju force-pushed the topic_systemd-2.0-CVE-2025-4598 branch from 97bd0c8 to 739b20b Compare July 3, 2025 12:01
@akhila-guruju akhila-guruju marked this pull request as ready for review July 8, 2025 04:15
@@ -290,6 +292,9 @@ fi
%files lang -f %{name}.lang

%changelog
* Mon Jul 03 2025 Akhila Guruju <v-guakhila@microsoft.com> - 250.3-23
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test Build Triggered.

Copy link
Member

@mfrw mfrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test build has failed. Can we please take a look.

Copy link
Member

@mfrw mfrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
The failing tests are not a regression.

@Malateshk007 Malateshk007 requested a review from dmcilvaney July 9, 2025 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
main PR Destined for main Packaging security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants