Skip to content

Patch frr for CVE-2024-55553 [High] #14041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 20, 2025

Conversation

Kanishk-Bansal
Copy link
Contributor

@Kanishk-Bansal Kanishk-Bansal commented Jun 19, 2025

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

What does the PR accomplish, why was it needed?

Patch Summary

Backports the upstream CVE-2024-55553 fix to FRRouting’s BGP RPKI code.

a. bgpd/bgp_rpki.c

  • Removes the function and all uses of revalidate_all_routes().
  • Removes use of t_revalidate_all arrays for bulk revalidation.
  • Changes bulk revalidation to only operate on single prefixes using the new revalidate_single_prefix() function.
  • Moves from using global/static variables to per-VRF context (e.g., struct rpki_vrf *rpki_vrf argument passing).
  • Drops the is_stopping() function in favor of checking a flag directly.

b. bgpd/bgpd.c

  • Removes cancellation of t_revalidate_all events in peer_free() and peer_delete().

c. bgpd/bgpd.h

  • Removes the definition of struct event *t_revalidate_all[AFI_MAX][SAFI_MAX]; from struct peer.
Change Log
Does this affect the toolchain?

No

Associated issues
  • #xxxx
Links to CVEs
Test Methodology

@mbykhovtsev-ms mbykhovtsev-ms added the CVEFixReadyForMaintainerReview When a CVE fix has been reviewed by release manager and is ready for stable maintainer review label Jun 20, 2025
@jslobodzian jslobodzian merged commit 052c91a into fasttrack/3.0 Jun 20, 2025
28 checks passed
@jslobodzian jslobodzian deleted the kanbansal/CVE-2024-55553/frr/3.0 branch June 20, 2025 19:43
CBL-Mariner-Bot pushed a commit that referenced this pull request Jun 20, 2025
Co-authored-by: Kanishk Bansal <kanbansal@microsoft.com>
(cherry picked from commit 052c91a)
@CBL-Mariner-Bot
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CVEFixReadyForMaintainerReview When a CVE fix has been reviewed by release manager and is ready for stable maintainer review fasttrack/3.0 PRs Destined for Azure Linux 3.0 Packaging security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants