Skip to content

[MEDIUM] Patch for iputils CVE-2025-47268 #14049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: 3.0-dev
Choose a base branch
from

Conversation

aninda-al
Copy link
Contributor

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

Address CVE-2025-47268

Patch Modified: No
Astrolabe patch reference: iputils/iputils@b41e4a1

Change Log
  • modified: SPECS/iputils/iputils.spec
  • added: SPECS/iputils/CVE-2025-47268.patch
Does this affect the toolchain?

NO

Associated issues
  • NA
Links to CVEs
Test Methodology
  • local build
  • Patch applies cleanly, please refer the following log snippet
    image

Note: There is an existing test failure for this package, and I did verify that it was not introduced by my changes. Original test fail log attached
iputils-20240117-1.azl3.src.rpm-FAILED_TEST-1750355241203.log

@microsoft-github-policy-service microsoft-github-policy-service bot added Packaging 3.0-dev PRs Destined for AzureLinux 3.0 labels Jun 19, 2025
@aninda-al aninda-al marked this pull request as ready for review June 20, 2025 11:04
@aninda-al aninda-al requested a review from a team as a code owner June 20, 2025 11:04
@realsdx
Copy link
Contributor

realsdx commented Jun 27, 2025

Buddy Build

Copy link
Contributor

@realsdx realsdx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Patch solves the issue
  • Security tag exists
  • Release bump & Changelog
  • Buddy Build

Buddy Build shows an unexpected pass:

 time="2025-06-25T13:49:25Z" level=debug msg=" 6/35 ping -6 -c1 localhost         UNEXPECTEDPASS  0.02s"

The test failure is due to the patch file ping_test_ipv6_localhost.patch. It is not related to any changes introduced by this PR.

However, it appears that we shouldn't include this patch in the 3.0 release, as in the 3.0 release, 'localhost' is mapped to IPv6 addresses by default.

@aninda-al
Copy link
Contributor Author

  • Patch solves the issue
  • Security tag exists
  • Release bump & Changelog
  • Buddy Build

Buddy Build shows an unexpected pass:

 time="2025-06-25T13:49:25Z" level=debug msg=" 6/35 ping -6 -c1 localhost         UNEXPECTEDPASS  0.02s"

The test failure is due to the patch file ping_test_ipv6_localhost.patch. It is not related to any changes introduced by this PR.

However, it appears that we shouldn't include this patch in the 3.0 release, as in the 3.0 release, 'localhost' is mapped to IPv6 addresses by default.

@realsdx Since you have already approved it, I am not sure if you are expecting me get rid of this patch file. Could you please confirm? Thanks!

@realsdx realsdx self-requested a review June 29, 2025 15:01
@realsdx
Copy link
Contributor

realsdx commented Jun 29, 2025

  • Patch solves the issue
  • Security tag exists
  • Release bump & Changelog
  • Buddy Build

Buddy Build shows an unexpected pass:

 time="2025-06-25T13:49:25Z" level=debug msg=" 6/35 ping -6 -c1 localhost         UNEXPECTEDPASS  0.02s"

The test failure is due to the patch file ping_test_ipv6_localhost.patch. It is not related to any changes introduced by this PR.
However, it appears that we shouldn't include this patch in the 3.0 release, as in the 3.0 release, 'localhost' is mapped to IPv6 addresses by default.

@realsdx Since you have already approved it, I am not sure if you are expecting me get rid of this patch file. Could you please confirm? Thanks!

Yes, fix the ptest as well. (Sorry, I wasn't sure how to undo the approval)

@aninda-al aninda-al force-pushed the v-anipradhan/iputils/CVE-2025-47268-3.0 branch from 53f4c69 to b21db10 Compare July 2, 2025 00:46
@aninda-al
Copy link
Contributor Author

  • Patch solves the issue
  • Security tag exists
  • Release bump & Changelog
  • Buddy Build

Buddy Build shows an unexpected pass:

 time="2025-06-25T13:49:25Z" level=debug msg=" 6/35 ping -6 -c1 localhost         UNEXPECTEDPASS  0.02s"

The test failure is due to the patch file ping_test_ipv6_localhost.patch. It is not related to any changes introduced by this PR.
However, it appears that we shouldn't include this patch in the 3.0 release, as in the 3.0 release, 'localhost' is mapped to IPv6 addresses by default.

@realsdx Since you have already approved it, I am not sure if you are expecting me get rid of this patch file. Could you please confirm? Thanks!

Yes, fix the ptest as well. (Sorry, I wasn't sure how to undo the approval)

@realsdx I made the changes as suggested and verified that the test failure is fixed.

@realsdx
Copy link
Contributor

realsdx commented Jul 8, 2025

Copy link
Contributor

@realsdx realsdx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.0-dev PRs Destined for AzureLinux 3.0 Packaging security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants