-
Notifications
You must be signed in to change notification settings - Fork 587
[Low] Patch cmake for CVE-2025-5916, CVE-2025-5917 & CVE-2025-5918 #14052
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
e38a588
to
4e0396f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR patches cmake to address CVE-2025-5916, CVE-2025-5917, and CVE-2025-5918 by applying upstream fixes from libarchive and updating version numbers accordingly.
- Bump cmake release version and update manifests for x86_64 and aarch64.
- Add three patch files for the corresponding CVEs with modifications in files handling file skip operations and entry name building in libarchive.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
toolkit/resources/manifests/package/toolchain_x86_64.txt | Bump cmake RPM version for x86_64. |
toolkit/resources/manifests/package/toolchain_aarch64.txt | Bump cmake RPM version for aarch64. |
SPECS/cmake/cmake.spec | Update Release field and add new patch entries for the three CVEs. |
SPECS/cmake/CVE-2025-5916.patch | Patch archive_read_support_format_warc.c to verify _warc_skip return value. |
SPECS/cmake/CVE-2025-5917.patch | Adjust constants in archive_write_set_format_pax.c for building entry names. |
SPECS/cmake/CVE-2025-5918.patch | Update several libarchive files to add file size checks and improve lseek behavior. |
Patch for CVE-2025-5916, CVE-2025-5917 LGTM to me |
For CVE-2025-5918 how have you validated these changes? |
Hi @Kanishk-Bansal, This skip addition, This skip prevents seeking beyond the end of the file. -thanks! |
4e0396f
to
9ac4c86
Compare
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-static
subpackages, etc.) have had theirRelease
tag incremented../cgmanifest.json
,./toolkit/scripts/toolchain/cgmanifest.json
,.github/workflows/cgmanifest.json
)./LICENSES-AND-NOTICES/SPECS/data/licenses.json
,./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md
,./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON
)*.signatures.json
filessudo make go-tidy-all
andsudo make go-test-coverage
passSummary
Patch cmake for CVE-2025-5916 & CVE-2025-5917 & CVE-2025-5918
For CVE-2025-5916
Astrolabe patch reference: libarchive/libarchive#2568
Patch modified: No.
- Only one file available in azure source archive_read_support_format_warc.c
- And non available files in Azure source are Makefile.am, test_read_format_warc.c and test_read_format_warc_incomplete.warc.uu
For CVE-2025-5917
Astrolabe patch reference: libarchive/libarchive#2588
Patch modified: No.
Astroloabe patch reference: libarchive/libarchive#2588
For CVE-2025-5918
Astrolabe patch reference: libarchive/libarchive#2584
Patch modified: yes.
- Added new variable "skip" with data type "int64_t" and assigned with "request;" to match the code with Upstream patch.
- One test file is not available in azure source code: archive_read_open_filename.c
Change Log
Does this affect the toolchain?
Yes
Associated issues
Links to CVEs
Test Methodology
-Built successfully with tests.

cmake-3.21.4-19.cm2.src.rpm.log
cmake-3.21.4-19.cm2.src.rpm.test.log